From 40dfeffecc14a0f627cd495b911221566a4215b5 Mon Sep 17 00:00:00 2001 From: Jeremy Elbourn Date: Mon, 23 Sep 2024 13:33:35 -0700 Subject: [PATCH] Explicitly set `standalone` for all Angular components Angular v19 is going to change the default value for `standalone` from `false` to `true`. Even though tensorboard is on an older version of Angular on GitHub, the version inside Google runs at HEAD. We're in the process of changing existing code in google to explicitly set `standalone: false` for existing code, so I'm sending this change to the source of truth here. --- .../debugger_v2/tf_debugger_v2_plugin/debugger_component.ts | 1 + .../debugger_v2/tf_debugger_v2_plugin/debugger_container.ts | 1 + .../debugger_v2/tf_debugger_v2_plugin/testing/index.ts | 1 + .../tf_debugger_v2_plugin/views/alerts/alerts_component.ts | 1 + .../tf_debugger_v2_plugin/views/alerts/alerts_container.ts | 1 + .../debug_tensor_value/debug_tensor_value_component.ts | 6 ++++++ .../views/execution_data/execution_data_component.ts | 1 + .../views/execution_data/execution_data_container.ts | 1 + .../tf_debugger_v2_plugin/views/graph/graph_component.ts | 1 + .../tf_debugger_v2_plugin/views/graph/graph_container.ts | 1 + .../tf_debugger_v2_plugin/views/graph/graph_op_component.ts | 1 + .../views/graph_executions/graph_executions_component.ts | 1 + .../views/graph_executions/graph_executions_container.ts | 1 + .../views/inactive/inactive_component.ts | 1 + .../views/inactive/inactive_container.ts | 1 + .../views/source_files/source_files_component.ts | 1 + .../views/source_files/source_files_container.ts | 1 + .../views/stack_trace/stack_trace_component.ts | 1 + .../views/stack_trace/stack_trace_container.ts | 1 + .../views/timeline/timeline_component.ts | 1 + .../views/timeline/timeline_container.ts | 1 + .../webapp/alert/views/alert_display_snackbar_container.ts | 1 + tensorboard/webapp/alert/views/alert_snackbar_container.ts | 1 + tensorboard/webapp/app_container.ts | 1 + .../webapp/app_routing/route_registry_module_test.ts | 3 +++ tensorboard/webapp/app_routing/views/router_link_test.ts | 2 ++ .../webapp/app_routing/views/router_outlet_component.ts | 1 + .../webapp/app_routing/views/router_outlet_container.ts | 1 + tensorboard/webapp/app_routing/views/router_outlet_test.ts | 2 ++ .../webapp/core/views/dark_mode_supporter_container.ts | 1 + tensorboard/webapp/core/views/hash_storage_component.ts | 1 + tensorboard/webapp/core/views/hash_storage_container.ts | 1 + tensorboard/webapp/core/views/layout_container.ts | 1 + tensorboard/webapp/core/views/layout_test.ts | 3 +++ tensorboard/webapp/core/views/page_title_component.ts | 1 + tensorboard/webapp/core/views/page_title_container.ts | 1 + tensorboard/webapp/core/views/page_title_test.ts | 1 + tensorboard/webapp/customization/customizable_component.ts | 2 ++ tensorboard/webapp/customization/customization_test.ts | 2 ++ .../feature_flag/directives/feature_flag_directive_test.ts | 2 ++ .../feature_flag/views/feature_flag_dialog_component.ts | 1 + .../feature_flag/views/feature_flag_dialog_container.ts | 1 + .../views/feature_flag_modal_trigger_container.ts | 1 + .../views/feature_flag_modal_trigger_container_test.ts | 1 + tensorboard/webapp/header/dark_mode_toggle_component.ts | 1 + tensorboard/webapp/header/dark_mode_toggle_container.ts | 1 + tensorboard/webapp/header/header_component.ts | 1 + tensorboard/webapp/header/plugin_selector_component.ts | 1 + tensorboard/webapp/header/plugin_selector_container.ts | 1 + tensorboard/webapp/header/reload_container.ts | 1 + .../webapp/metrics/views/card_renderer/card_lazy_loader.ts | 1 + .../metrics/views/card_renderer/card_lazy_loader_test.ts | 2 ++ .../metrics/views/card_renderer/card_view_component.ts | 1 + .../metrics/views/card_renderer/card_view_container.ts | 1 + .../webapp/metrics/views/card_renderer/card_view_test.ts | 1 + .../views/card_renderer/data_download_dialog_component.ts | 1 + .../views/card_renderer/data_download_dialog_container.ts | 1 + .../metrics/views/card_renderer/histogram_card_component.ts | 1 + .../metrics/views/card_renderer/histogram_card_container.ts | 1 + .../metrics/views/card_renderer/histogram_card_test.ts | 1 + .../metrics/views/card_renderer/image_card_component.ts | 1 + .../metrics/views/card_renderer/image_card_container.ts | 1 + .../webapp/metrics/views/card_renderer/image_card_test.ts | 1 + .../metrics/views/card_renderer/run_name_component.ts | 1 + .../metrics/views/card_renderer/run_name_container.ts | 1 + .../metrics/views/card_renderer/scalar_card_component.ts | 1 + .../metrics/views/card_renderer/scalar_card_container.ts | 1 + .../metrics/views/card_renderer/scalar_card_data_table.ts | 1 + .../views/card_renderer/scalar_card_fob_controller.ts | 1 + .../views/card_renderer/scalar_card_line_chart_component.ts | 1 + .../views/card_renderer/scalar_card_line_chart_container.ts | 1 + .../views/card_renderer/scalar_card_line_chart_test.ts | 2 ++ .../webapp/metrics/views/card_renderer/scalar_card_test.ts | 2 ++ .../vis_linked_time_selection_warning_component.ts | 1 + .../webapp/metrics/views/main_view/card_grid_component.ts | 1 + .../webapp/metrics/views/main_view/card_grid_container.ts | 1 + .../webapp/metrics/views/main_view/card_grid_test.ts | 1 + .../metrics/views/main_view/card_group_toolbar_component.ts | 1 + .../metrics/views/main_view/card_group_toolbar_container.ts | 1 + .../webapp/metrics/views/main_view/card_groups_component.ts | 1 + .../webapp/metrics/views/main_view/card_groups_container.ts | 1 + .../views/main_view/empty_tag_match_message_component.ts | 1 + .../views/main_view/empty_tag_match_message_container.ts | 1 + .../metrics/views/main_view/filter_input_component.ts | 1 + .../metrics/views/main_view/filter_input_container.ts | 1 + .../metrics/views/main_view/filtered_view_component.ts | 1 + .../metrics/views/main_view/filtered_view_container.ts | 1 + .../webapp/metrics/views/main_view/main_view_component.ts | 1 + .../webapp/metrics/views/main_view/main_view_container.ts | 1 + .../webapp/metrics/views/main_view/main_view_test.ts | 2 ++ .../webapp/metrics/views/main_view/pinned_view_component.ts | 1 + .../webapp/metrics/views/main_view/pinned_view_container.ts | 1 + tensorboard/webapp/metrics/views/metrics_container.ts | 1 + .../webapp/metrics/views/right_pane/right_pane_component.ts | 1 + .../views/right_pane/saving_pins_checkbox_component.ts | 1 + .../saving_pins_dialog/saving_pins_dialog_component.ts | 1 + .../scalar_column_editor/scalar_column_editor_component.ts | 1 + .../scalar_column_editor/scalar_column_editor_container.ts | 1 + .../metrics/views/right_pane/settings_view_component.ts | 1 + .../metrics/views/right_pane/settings_view_container.ts | 1 + .../_views/notification_center_component.ts | 1 + .../_views/notification_center_container.ts | 1 + tensorboard/webapp/plugins/plugins_component.ts | 1 + tensorboard/webapp/plugins/plugins_container.ts | 1 + tensorboard/webapp/plugins/plugins_container_test.ts | 1 + tensorboard/webapp/plugins/testing/index.ts | 1 + tensorboard/webapp/reloader/reloader_component.ts | 1 + .../runs/views/runs_selector/runs_selector_component.ts | 1 + .../runs/views/runs_selector/runs_selector_container.ts | 1 + .../webapp/runs/views/runs_table/filterbar_component.ts | 1 + .../webapp/runs/views/runs_table/filterbar_container.ts | 1 + tensorboard/webapp/runs/views/runs_table/filterbar_test.ts | 1 + .../runs/views/runs_table/regex_edit_dialog_component.ts | 1 + .../runs/views/runs_table/regex_edit_dialog_container.ts | 1 + tensorboard/webapp/runs/views/runs_table/runs_data_table.ts | 1 + .../webapp/runs/views/runs_table/runs_data_table_test.ts | 1 + .../views/runs_table/runs_group_menu_button_component.ts | 1 + .../views/runs_table/runs_group_menu_button_container.ts | 1 + .../webapp/runs/views/runs_table/runs_table_container.ts | 1 + .../legacy_runs_selector/legacy_runs_selector_component.ts | 1 + .../legacy_runs_selector/legacy_runs_selector_container.ts | 1 + .../webapp/settings/_views/polymer_interop_container.ts | 1 + .../webapp/settings/_views/settings_button_component.ts | 1 + .../webapp/settings/_views/settings_button_container.ts | 1 + .../webapp/settings/_views/settings_dialog_component.ts | 1 + .../webapp/settings/_views/settings_dialog_container.ts | 1 + tensorboard/webapp/tb_wrapper/tb_wrapper_component.ts | 1 + tensorboard/webapp/testing/integration_test_module.ts | 1 + tensorboard/webapp/testing/mat_icon_module.ts | 1 + tensorboard/webapp/widgets/card_fob/card_fob_component.ts | 1 + .../widgets/card_fob/card_fob_controller_component.ts | 1 + .../webapp/widgets/card_fob/card_fob_controller_test.ts | 1 + tensorboard/webapp/widgets/card_fob/card_fob_test.ts | 1 + .../content_wrapping_input_component.ts | 1 + .../content_wrapping_input/content_wrapping_input_test.ts | 1 + .../webapp/widgets/custom_modal/custom_modal_test.ts | 1 + .../webapp/widgets/data_table/column_selector_component.ts | 1 + .../webapp/widgets/data_table/content_cell_component.ts | 1 + .../widgets/data_table/content_cell_component_test.ts | 1 + .../webapp/widgets/data_table/content_row_component.ts | 1 + .../webapp/widgets/data_table/context_menu_component.ts | 1 + .../webapp/widgets/data_table/data_table_component.ts | 1 + .../widgets/data_table/data_table_header_component.ts | 1 + tensorboard/webapp/widgets/data_table/data_table_test.ts | 1 + .../webapp/widgets/data_table/filter_dialog_component.ts | 1 + .../webapp/widgets/data_table/header_cell_component.ts | 1 + .../webapp/widgets/data_table/header_cell_component_test.ts | 1 + tensorboard/webapp/widgets/dropdown/dropdown_component.ts | 1 + tensorboard/webapp/widgets/dropdown/dropdown_test.ts | 1 + .../widgets/experiment_alias/experiment_alias_component.ts | 1 + .../widgets/experiment_alias/experiment_alias_test.ts | 1 + .../webapp/widgets/filter_input/filter_input_component.ts | 1 + .../webapp/widgets/filter_input/filter_input_test.ts | 2 ++ .../widgets/histogram/histogram_card_fob_controller.ts | 1 + tensorboard/webapp/widgets/histogram/histogram_component.ts | 1 + tensorboard/webapp/widgets/histogram/histogram_test.ts | 1 + .../intersection_observer/intersection_observer_test.ts | 1 + .../webapp/widgets/line_chart_v2/line_chart_component.ts | 1 + .../widgets/line_chart_v2/line_chart_component_test.ts | 2 ++ .../widgets/line_chart_v2/sub_view/line_chart_axis_view.ts | 1 + .../line_chart_v2/sub_view/line_chart_axis_view_test.ts | 1 + .../widgets/line_chart_v2/sub_view/line_chart_grid_view.ts | 1 + .../line_chart_v2/sub_view/line_chart_grid_view_test.ts | 1 + .../line_chart_v2/sub_view/line_chart_interactive_view.ts | 1 + .../sub_view/line_chart_interactive_view_test.ts | 1 + .../markdown_renderer/markdown_renderer_component.ts | 1 + .../markdown_renderer/markdown_renderer_component_test.ts | 1 + .../webapp/widgets/range_input/range_input_component.ts | 1 + tensorboard/webapp/widgets/range_input/range_input_test.ts | 1 + tensorboard/webapp/widgets/resize_detector_test.ts | 1 + .../webapp/widgets/source_code/source_code_component.ts | 1 + .../webapp/widgets/source_code/source_code_container.ts | 1 + .../widgets/source_code/source_code_container_test.ts | 1 + .../widgets/source_code/source_code_diff_component.ts | 1 + .../widgets/source_code/source_code_diff_container.ts | 1 + .../widgets/source_code/source_code_diff_container_test.ts | 1 + tensorboard/webapp/widgets/text/truncated_path_component.ts | 1 + 177 files changed, 197 insertions(+) diff --git a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/debugger_component.ts b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/debugger_component.ts index 8ccb00a3e7..22d59d7eea 100644 --- a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/debugger_component.ts +++ b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/debugger_component.ts @@ -16,6 +16,7 @@ import {ChangeDetectionStrategy, Component, Input} from '@angular/core'; import {DebuggerRunListing} from './store/debugger_types'; @Component({ + standalone: false, selector: 'debugger-component', templateUrl: './debugger_component.ng.html', styleUrls: ['./debugger_component.css'], diff --git a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/debugger_container.ts b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/debugger_container.ts index ac03294a65..e2865d6534 100644 --- a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/debugger_container.ts +++ b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/debugger_container.ts @@ -19,6 +19,7 @@ import {getActiveRunId, getDebuggerRunListing} from './store'; import {State} from './store/debugger_types'; @Component({ + standalone: false, selector: 'tf-debugger-v2', template: ` @@ -205,6 +209,7 @@ export class DebugTensorNumericBreakdownComponent { } @Component({ + standalone: false, selector: 'debug-tensor-has-inf-or-nan', template: `
@@ -242,6 +247,7 @@ export class DebugTensorHasInfOrNaNComponent { } @Component({ + standalone: false, selector: 'debug-tensor-value', template: ` `, }) diff --git a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/source_files/source_files_component.ts b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/source_files/source_files_component.ts index 05b00bf1f9..4dda714fc2 100644 --- a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/source_files/source_files_component.ts +++ b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/source_files/source_files_component.ts @@ -24,6 +24,7 @@ import {SourceFileContent, StackFrame} from '../../store/debugger_types'; * displayed by this component. */ @Component({ + standalone: false, selector: 'source-files-component', templateUrl: './source_files_component.ng.html', styleUrls: ['./source_files_component.css'], diff --git a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/source_files/source_files_container.ts b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/source_files/source_files_container.ts index f83160c2ce..dd9e2089d4 100644 --- a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/source_files/source_files_container.ts +++ b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/source_files/source_files_container.ts @@ -24,6 +24,7 @@ import { import {State as DebuggerState} from '../../store/debugger_types'; @Component({ + standalone: false, selector: 'tf-debugger-v2-source-files', template: ` testable link', }) @@ -36,6 +37,7 @@ class TestableComponent { } @Component({ + standalone: false, selector: 'test-with-reset', template: 'testable link', diff --git a/tensorboard/webapp/app_routing/views/router_outlet_component.ts b/tensorboard/webapp/app_routing/views/router_outlet_component.ts index 20d4409a09..db0becb2eb 100644 --- a/tensorboard/webapp/app_routing/views/router_outlet_component.ts +++ b/tensorboard/webapp/app_routing/views/router_outlet_component.ts @@ -24,6 +24,7 @@ import { } from '@angular/core'; @Component({ + standalone: false, selector: 'router-outlet-component', template: ` `, changeDetection: ChangeDetectionStrategy.OnPush, diff --git a/tensorboard/webapp/app_routing/views/router_outlet_container.ts b/tensorboard/webapp/app_routing/views/router_outlet_container.ts index 554fe5c459..8466fa9b48 100644 --- a/tensorboard/webapp/app_routing/views/router_outlet_container.ts +++ b/tensorboard/webapp/app_routing/views/router_outlet_container.ts @@ -25,6 +25,7 @@ import { } from '../store/app_routing_selectors'; @Component({ + standalone: false, selector: 'router-outlet', template: ` diff --git a/tensorboard/webapp/core/views/page_title_component.ts b/tensorboard/webapp/core/views/page_title_component.ts index 6b42871e2d..c2d06f5d8e 100644 --- a/tensorboard/webapp/core/views/page_title_component.ts +++ b/tensorboard/webapp/core/views/page_title_component.ts @@ -29,6 +29,7 @@ const utils = { }; @Component({ + standalone: false, selector: 'page-title-component', template: '', changeDetection: ChangeDetectionStrategy.OnPush, diff --git a/tensorboard/webapp/core/views/page_title_container.ts b/tensorboard/webapp/core/views/page_title_container.ts index 8cf5927b0c..5d92f9de29 100644 --- a/tensorboard/webapp/core/views/page_title_container.ts +++ b/tensorboard/webapp/core/views/page_title_container.ts @@ -43,6 +43,7 @@ const DEFAULT_BRAND_NAME = 'TensorBoard'; * Renders page title. */ @Component({ + standalone: false, selector: 'page-title', template: ` diff --git a/tensorboard/webapp/core/views/page_title_test.ts b/tensorboard/webapp/core/views/page_title_test.ts index 3521996ac3..1d208e6a7c 100644 --- a/tensorboard/webapp/core/views/page_title_test.ts +++ b/tensorboard/webapp/core/views/page_title_test.ts @@ -112,6 +112,7 @@ describe('page title test', () => { }); @Component({ + standalone: false, selector: 'my-tester', template: ` `, }) diff --git a/tensorboard/webapp/customization/customizable_component.ts b/tensorboard/webapp/customization/customizable_component.ts index aa809d4341..bf8ef00229 100644 --- a/tensorboard/webapp/customization/customizable_component.ts +++ b/tensorboard/webapp/customization/customizable_component.ts @@ -58,6 +58,7 @@ import { * * @Injectable() * @Component({ + * standalone: false, * selector: 'my-custom-button-component', * template: '' * }) @@ -74,6 +75,7 @@ import { * }) */ @Component({ + standalone: false, selector: 'tb-customization', template: ` diff --git a/tensorboard/webapp/customization/customization_test.ts b/tensorboard/webapp/customization/customization_test.ts index 73211b832f..c910ac123b 100644 --- a/tensorboard/webapp/customization/customization_test.ts +++ b/tensorboard/webapp/customization/customization_test.ts @@ -26,6 +26,7 @@ export class CustomizableComponentType {} * Parent class that uses the component. */ @Component({ + standalone: false, selector: 'parent-component', template: ` @@ -54,6 +55,7 @@ export class ParentComponentModule {} * into the ParentComponent for some tests. */ @Component({ + standalone: false, selector: 'customizable-component', template: `
Showing Customized Text!
`, }) diff --git a/tensorboard/webapp/feature_flag/directives/feature_flag_directive_test.ts b/tensorboard/webapp/feature_flag/directives/feature_flag_directive_test.ts index 3fff2603f9..042762d1b1 100644 --- a/tensorboard/webapp/feature_flag/directives/feature_flag_directive_test.ts +++ b/tensorboard/webapp/feature_flag/directives/feature_flag_directive_test.ts @@ -26,6 +26,7 @@ import {State as FeatureFlagState} from '../store/feature_flag_types'; import {FeatureFlagDirective} from './feature_flag_directive'; @Component({ + standalone: false, selector: 'test-matching-selector', template: `

@@ -40,6 +41,7 @@ export class TestMatchingComponent { } @Component({ + standalone: false, selector: 'test-nonmatching-selector', template: `

diff --git a/tensorboard/webapp/feature_flag/views/feature_flag_dialog_component.ts b/tensorboard/webapp/feature_flag/views/feature_flag_dialog_component.ts index 7c67196e52..b749959e72 100644 --- a/tensorboard/webapp/feature_flag/views/feature_flag_dialog_component.ts +++ b/tensorboard/webapp/feature_flag/views/feature_flag_dialog_component.ts @@ -18,6 +18,7 @@ import {FeatureFlags} from '../types'; import {FeatureFlagStatus, FeatureFlagStatusEvent} from './types'; @Component({ + standalone: false, selector: 'feature-flag-dialog-component', styleUrls: ['feature_flag_dialog_component.css'], templateUrl: `feature_flag_dialog_component.ng.html`, diff --git a/tensorboard/webapp/feature_flag/views/feature_flag_dialog_container.ts b/tensorboard/webapp/feature_flag/views/feature_flag_dialog_container.ts index 38f2d8b3e7..2a90abfd76 100644 --- a/tensorboard/webapp/feature_flag/views/feature_flag_dialog_container.ts +++ b/tensorboard/webapp/feature_flag/views/feature_flag_dialog_container.ts @@ -40,6 +40,7 @@ import { } from './types'; @Component({ + standalone: false, selector: 'feature-flag-dialog', template: `Test

', jit: true, diff --git a/tensorboard/webapp/header/dark_mode_toggle_component.ts b/tensorboard/webapp/header/dark_mode_toggle_component.ts index 8b43e372fe..40aae27cc2 100644 --- a/tensorboard/webapp/header/dark_mode_toggle_component.ts +++ b/tensorboard/webapp/header/dark_mode_toggle_component.ts @@ -21,6 +21,7 @@ export enum DarkModeOverride { } @Component({ + standalone: false, selector: 'app-header-dark-mode-toggle-component', template: ` diff --git a/tensorboard/webapp/widgets/data_table/column_selector_component.ts b/tensorboard/webapp/widgets/data_table/column_selector_component.ts index 8ff421384b..fffdb11c5c 100644 --- a/tensorboard/webapp/widgets/data_table/column_selector_component.ts +++ b/tensorboard/webapp/widgets/data_table/column_selector_component.ts @@ -28,6 +28,7 @@ import {ColumnHeader} from './types'; import {BehaviorSubject} from 'rxjs'; @Component({ + standalone: false, selector: 'tb-data-table-column-selector-component', templateUrl: 'column_selector_component.ng.html', styleUrls: ['column_selector_component.css'], diff --git a/tensorboard/webapp/widgets/data_table/content_cell_component.ts b/tensorboard/webapp/widgets/data_table/content_cell_component.ts index e4a644b6c4..bf7c226270 100644 --- a/tensorboard/webapp/widgets/data_table/content_cell_component.ts +++ b/tensorboard/webapp/widgets/data_table/content_cell_component.ts @@ -28,6 +28,7 @@ import { } from '../line_chart_v2/lib/formatter'; @Component({ + standalone: false, selector: 'tb-data-table-content-cell', templateUrl: 'content_cell_component.ng.html', styleUrls: ['content_cell_component.css'], diff --git a/tensorboard/webapp/widgets/data_table/content_cell_component_test.ts b/tensorboard/webapp/widgets/data_table/content_cell_component_test.ts index 658b58f91f..93b48e2ba7 100644 --- a/tensorboard/webapp/widgets/data_table/content_cell_component_test.ts +++ b/tensorboard/webapp/widgets/data_table/content_cell_component_test.ts @@ -22,6 +22,7 @@ import {DataTableModule} from './data_table_module'; import {ContentCellComponent} from './content_cell_component'; @Component({ + standalone: false, selector: 'testable-comp', template: ` `, styles: [ diff --git a/tensorboard/webapp/widgets/data_table/context_menu_component.ts b/tensorboard/webapp/widgets/data_table/context_menu_component.ts index c8badab914..990797d796 100644 --- a/tensorboard/webapp/widgets/data_table/context_menu_component.ts +++ b/tensorboard/webapp/widgets/data_table/context_menu_component.ts @@ -23,6 +23,7 @@ import { import {ColumnHeader, Side, SortingInfo, SortingOrder} from './types'; @Component({ + standalone: false, selector: 'tb-data-table-context-menu', templateUrl: 'context_menu_component.ng.html', styleUrls: ['context_menu_component.css'], diff --git a/tensorboard/webapp/widgets/data_table/data_table_component.ts b/tensorboard/webapp/widgets/data_table/data_table_component.ts index f4e1f108e1..3a4fce1a3b 100644 --- a/tensorboard/webapp/widgets/data_table/data_table_component.ts +++ b/tensorboard/webapp/widgets/data_table/data_table_component.ts @@ -53,6 +53,7 @@ const preventDefault = function (e: MouseEvent) { }; @Component({ + standalone: false, selector: 'tb-data-table', templateUrl: 'data_table_component.ng.html', styleUrls: ['data_table_component.css'], diff --git a/tensorboard/webapp/widgets/data_table/data_table_header_component.ts b/tensorboard/webapp/widgets/data_table/data_table_header_component.ts index 63f84a255d..100ce39d75 100644 --- a/tensorboard/webapp/widgets/data_table/data_table_header_component.ts +++ b/tensorboard/webapp/widgets/data_table/data_table_header_component.ts @@ -17,6 +17,7 @@ import {ChangeDetectionStrategy, Component, Input} from '@angular/core'; import {ColumnHeader, ColumnHeaderType} from './types'; @Component({ + standalone: false, selector: 'tb-data-table-header', templateUrl: 'data_table_header_component.ng.html', styleUrls: ['data_table_header_component.css'], diff --git a/tensorboard/webapp/widgets/data_table/data_table_test.ts b/tensorboard/webapp/widgets/data_table/data_table_test.ts index 6ec0d1b542..4e7e8faa2d 100644 --- a/tensorboard/webapp/widgets/data_table/data_table_test.ts +++ b/tensorboard/webapp/widgets/data_table/data_table_test.ts @@ -48,6 +48,7 @@ import {CustomModal} from '../custom_modal/custom_modal'; const ADD_BUTTON_PREDICATE = By.css('.add-button'); @Component({ + standalone: false, selector: 'testable-comp', template: ` . */ @Component({ + standalone: false, selector: 'tb-dropdown', template: ` component. */ @Component({ + standalone: false, selector: 'testing-component', template: ` {{ alias.aliasNumber }} diff --git a/tensorboard/webapp/widgets/experiment_alias/experiment_alias_test.ts b/tensorboard/webapp/widgets/experiment_alias/experiment_alias_test.ts index 0699ab49aa..794e5e0789 100644 --- a/tensorboard/webapp/widgets/experiment_alias/experiment_alias_test.ts +++ b/tensorboard/webapp/widgets/experiment_alias/experiment_alias_test.ts @@ -21,6 +21,7 @@ import {ContentWrappingInputModule} from '../content_wrapping_input/content_wrap import {ExperimentAliasComponent} from './experiment_alias_component'; @Component({ + standalone: false, selector: 'testable', template: ` diff --git a/tensorboard/webapp/widgets/filter_input/filter_input_test.ts b/tensorboard/webapp/widgets/filter_input/filter_input_test.ts index 8b811c0b63..8c78d4d0af 100644 --- a/tensorboard/webapp/widgets/filter_input/filter_input_test.ts +++ b/tensorboard/webapp/widgets/filter_input/filter_input_test.ts @@ -24,6 +24,7 @@ import {MatIconTestingModule} from '../../testing/mat_icon_module'; import {FilterInputModule} from './filter_input_module'; @Component({ + standalone: false, selector: 'test', template: ` @@ -45,6 +46,7 @@ class TestableInputWithCompletions { } @Component({ + standalone: false, selector: 'test', template: ` `, }) diff --git a/tensorboard/webapp/widgets/histogram/histogram_card_fob_controller.ts b/tensorboard/webapp/widgets/histogram/histogram_card_fob_controller.ts index dd188539d8..e770597729 100644 --- a/tensorboard/webapp/widgets/histogram/histogram_card_fob_controller.ts +++ b/tensorboard/webapp/widgets/histogram/histogram_card_fob_controller.ts @@ -25,6 +25,7 @@ import { import {TemporalScale} from './histogram_component'; @Component({ + standalone: false, selector: 'histogram-card-fob-controller', template: ` diff --git a/tensorboard/webapp/widgets/line_chart_v2/line_chart_component.ts b/tensorboard/webapp/widgets/line_chart_v2/line_chart_component.ts index ec99acb10b..34d0c54923 100644 --- a/tensorboard/webapp/widgets/line_chart_v2/line_chart_component.ts +++ b/tensorboard/webapp/widgets/line_chart_v2/line_chart_component.ts @@ -70,6 +70,7 @@ export interface TemplateContext { } @Component({ + standalone: false, selector: 'line-chart', templateUrl: 'line_chart_component.ng.html', styleUrls: ['line_chart_component.css'], diff --git a/tensorboard/webapp/widgets/line_chart_v2/line_chart_component_test.ts b/tensorboard/webapp/widgets/line_chart_v2/line_chart_component_test.ts index a6aa46dee8..53edfbb729 100644 --- a/tensorboard/webapp/widgets/line_chart_v2/line_chart_component_test.ts +++ b/tensorboard/webapp/widgets/line_chart_v2/line_chart_component_test.ts @@ -38,6 +38,7 @@ import {buildMetadata, buildSeries} from './lib/testing'; import {LineChartComponent} from './line_chart_component'; @Component({ + standalone: false, selector: 'line-chart-grid-view', template: ``, }) @@ -50,6 +51,7 @@ class FakeGridComponent { } @Component({ + standalone: false, selector: 'testable-comp', template: ` ; @Component({ + standalone: false, selector: 'line-chart-interactive-view', templateUrl: './line_chart_interactive_view.ng.html', styleUrls: ['./line_chart_interactive_view.css'], diff --git a/tensorboard/webapp/widgets/line_chart_v2/sub_view/line_chart_interactive_view_test.ts b/tensorboard/webapp/widgets/line_chart_v2/sub_view/line_chart_interactive_view_test.ts index b31bcc3a96..27fb2568aa 100644 --- a/tensorboard/webapp/widgets/line_chart_v2/sub_view/line_chart_interactive_view_test.ts +++ b/tensorboard/webapp/widgets/line_chart_v2/sub_view/line_chart_interactive_view_test.ts @@ -38,6 +38,7 @@ interface Coord { } @Component({ + standalone: false, selector: 'testable-comp', template: ` `, }) diff --git a/tensorboard/webapp/widgets/range_input/range_input_component.ts b/tensorboard/webapp/widgets/range_input/range_input_component.ts index be2b4ae203..f14bca8884 100644 --- a/tensorboard/webapp/widgets/range_input/range_input_component.ts +++ b/tensorboard/webapp/widgets/range_input/range_input_component.ts @@ -60,6 +60,7 @@ enum Position { * - emits actions on range value changed */ @Component({ + standalone: false, selector: 'tb-range-input', templateUrl: './range_input_component.ng.html', styleUrls: ['./range_input_component.css'], diff --git a/tensorboard/webapp/widgets/range_input/range_input_test.ts b/tensorboard/webapp/widgets/range_input/range_input_test.ts index 80be84962e..c93dd935d5 100644 --- a/tensorboard/webapp/widgets/range_input/range_input_test.ts +++ b/tensorboard/webapp/widgets/range_input/range_input_test.ts @@ -22,6 +22,7 @@ import {RangeInputComponent} from './range_input_component'; import {RangeInputSource, RangeValues} from './types'; @Component({ + standalone: false, selector: 'testable-range-input', template: ` diff --git a/tensorboard/webapp/widgets/text/truncated_path_component.ts b/tensorboard/webapp/widgets/text/truncated_path_component.ts index 3f74dc2b36..722019dbfb 100644 --- a/tensorboard/webapp/widgets/text/truncated_path_component.ts +++ b/tensorboard/webapp/widgets/text/truncated_path_component.ts @@ -21,6 +21,7 @@ import {Component, Input} from '@angular/core'; * ellipsis. */ @Component({ + standalone: false, selector: 'tb-truncated-path', template: ` {{