Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong calculation of Inception score and FID for SAGAN without resizing #12

Open
giannisdaras opened this issue Dec 5, 2019 · 1 comment

Comments

@giannisdaras
Copy link

Hey and congratulations for this amazing library, I have been using it for our latest paper [paper], [code].

After the BREAKING CHANGE commit, the FID / Inception score is calculated wrongly for the SAGAN example. For ImageNet, it gives real inception score ~2.5.

After changing the sample_fn function defined here to perform the image resize, the correct FID and Inception scores are calculated.
I guess that is unexpected, since there is this comment, just in the above line:
# Image resizing happens inside the Inception SavedModel.

I managed to solve the problem by reshaping in the sample_fn function (as it was before the change), but I thought that it is worth bringing that to your attention :)

Let me know if you need any help!

@joel-shor
Copy link
Contributor

@aaronsarna We fixed this, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants