Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boundary argument is inconsistent in affine transforms #33

Open
mwallerb opened this issue Jan 24, 2025 · 0 comments
Open

boundary argument is inconsistent in affine transforms #33

mwallerb opened this issue Jan 24, 2025 · 0 comments

Comments

@mwallerb
Copy link
Collaborator

In fixing affine transforms through PR #32, the boundary argument is now sometimes a keyword argument and sometimes it is a positional argument.

I think this should be consistent. I would vote for a positional argument, maybe even make it mandatory (i.e., removing the default), because picking boundary conditions is very much part of what you should think of when constructing an affine transform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant