Skip to content

Commit

Permalink
Log prometheus listener error at Warn level (#7291)
Browse files Browse the repository at this point in the history
## What changed?
<!-- Describe what has changed in this PR -->
- Log prometheus listener error at Warn level

## Why?
<!-- Tell your future self why have you made these changes -->
- For backward compatibility. There might be some CI systems monitoring
logs and fail tests on Error logs.
  • Loading branch information
yycptt authored Feb 7, 2025
1 parent 1d568d0 commit fdc39ca
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion common/metrics/opentelemetry_provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,9 @@ func initPrometheusListener(
if fatalOnListenerError {
logger.Fatal(msg)
} else {
logger.Error(msg)
// For backward compatibility, we log as Warn instead of Error/Fatal
// to match the behavior of tally framework.
logger.Warn(msg)
}
}()

Expand Down

0 comments on commit fdc39ca

Please sign in to comment.