Skip to content

[Bug] test_unfinished_handler_on_workflow_termination fails in some situations with time skipping and update #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cretz opened this issue Apr 10, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@cretz
Copy link
Member

cretz commented Apr 10, 2025

Describe the bug

As part of #644 we were trying to unskip these tests. But they still fail.

Specifically, when running in Python 3.13 (and maybe others) with time skipping test server, all permutations of test_unfinished_handler_on_workflow_termination that use handler_type update, handler_waiting no-wait-all-handlers-finish, and workflow_termination_type continue-as-new fail with "workflow execution already completed".

To replicate, run:

poe test -s --log-cli-level=DEBUG --workflow-environment time-skipping -k test_unfinished_handler_on_workflow_termination

To see the failure. Leaving tests skipped for now.

@cretz cretz added the bug Something isn't working label Apr 10, 2025
@cretz cretz changed the title [Bug] test_unfinished_handler_on_workflow_termination fails in some situations with time skipping [Bug] test_unfinished_handler_on_workflow_termination fails in some situations with time skipping and update Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant