Skip to content

Commit a4b8d6f

Browse files
committed
Respond to upstream
1 parent 9cb9ef3 commit a4b8d6f

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tests/nexus/test_handler.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
import pytest
3131
from google.protobuf import json_format
3232
from nexusrpc.testing.client import ServiceClient
33-
from typing_extensions import Never
3433

3534
import temporalio.api.failure.v1
3635
import temporalio.nexus
@@ -72,7 +71,7 @@ class MyService:
7271
# echo_renamed: nexusrpc.Operation[Input, Output] = (
7372
# nexusrpc.Operation(name="echo-renamed")
7473
# )
75-
hang: nexusrpc.Operation[Input, Never]
74+
hang: nexusrpc.Operation[Input, Output]
7675
log: nexusrpc.Operation[Input, Output]
7776
async_operation: nexusrpc.Operation[Input, Output]
7877
async_operation_without_type_annotations: nexusrpc.Operation[Input, Output]
@@ -129,8 +128,9 @@ async def echo(
129128
@nexusrpc.handler.sync_operation_handler
130129
async def hang(
131130
self, ctx: nexusrpc.handler.StartOperationContext, input: Input
132-
) -> Never:
131+
) -> Output:
133132
await asyncio.Future()
133+
return Output(value="won't reach here")
134134

135135
@nexusrpc.handler.sync_operation_handler
136136
async def non_retryable_application_error(
@@ -636,7 +636,7 @@ class UnknownOperation(_FailureTestCase):
636636
status_code=404,
637637
retryable_header=False,
638638
failure_message=lambda s: s.startswith(
639-
"Nexus service contract 'MyService' has no operation 'NonExistentOperation'."
639+
"Nexus service definition 'MyService' has no operation 'NonExistentOperation'."
640640
),
641641
)
642642

0 commit comments

Comments
 (0)