Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure our proxy helpers forward metadata #1497

Closed
cretz opened this issue May 31, 2024 · 1 comment · Fixed by #1531
Closed

Ensure our proxy helpers forward metadata #1497

cretz opened this issue May 31, 2024 · 1 comment · Fixed by #1531
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented May 31, 2024

Describe the solution you'd like

This would be an issue for https://pkg.go.dev/go.temporal.io/api/proxy but there is no "issues" section there. Basically we need to confirm that when using the proxy library in the default way, that the headers like client-name/client-version flow through the proxy. Write a test and, if it's not flowing through, make it do so. This may just be a case of our code gen using https://pkg.go.dev/google.golang.org/grpc/metadata to populating incoming context to outgoing context (and adding an option to disable it). Probably can't have an interceptor since users control that part, we just control the service proxy helper.

@cretz cretz added the enhancement New feature or request label May 31, 2024
@cretz
Copy link
Member Author

cretz commented Jun 5, 2024

PR opened at temporalio/api-go#167 (which will be waiting for #1502 to be released before merging).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant