From c935b508d1f41c9bfd78ae2adff1fc4e4982f9d8 Mon Sep 17 00:00:00 2001 From: Sebastian Gumprich Date: Fri, 19 Apr 2024 10:05:55 +0200 Subject: [PATCH 1/2] set user_groups in notification to empty list in previous versions, the default was None, now it is an empty list. this would produce a diff --- plugins/modules/icinga_notification.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/plugins/modules/icinga_notification.py b/plugins/modules/icinga_notification.py index b637a28a..7e657edf 100644 --- a/plugins/modules/icinga_notification.py +++ b/plugins/modules/icinga_notification.py @@ -121,6 +121,7 @@ - User Groups that should be notified by this notification. type: "list" elements: str + default: [] version_added: '1.16.0' append: description: @@ -225,7 +226,7 @@ def main(): notification_interval=dict(type="int", required=False), states=dict(type="list", elements="str", required=False), users=dict(type="list", elements="str", required=False), - user_groups=dict(type="list", elements="str", required=False), + user_groups=dict(type="list", elements="str", default=[], required=False), types=dict(type="list", elements="str", required=False), vars=dict(type="dict", default={}, required=False), period=dict(required=False, aliases=["time_period"]), From ccb7840a9edbfc7b77b5212ea2a590fcbfa52223 Mon Sep 17 00:00:00 2001 From: Sebastian Gumprich Date: Fri, 19 Apr 2024 14:55:42 +0200 Subject: [PATCH 2/2] add version constraints and known bugs --- README.md | 8 +++++++- meta/runtime.yml | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index b7aa0003..694672e9 100644 --- a/README.md +++ b/README.md @@ -34,7 +34,9 @@ Additionally all supported modules have an appropriate `*_info`-module to gather 4. An [inventory plugin](plugins/inventory) to use hosts and groups defined in Icinga as a dynamic inventory. -Required Ansible version: 2.9.10 +Required Ansible version: 2.14.0 + +Recommended Icinga-Director version: 2.11.1 ## Installation @@ -194,6 +196,10 @@ failed: [localhost] => {"ansible_loop_var": "item", "changed": false, "item": "l ## Known Errors with different Director versions +### Director 1.11.1 + +When creating notifications that contain the `users`-parameter, the task might not be idempotent ([see](https://github.com/Icinga/icingaweb2-module-director/issues/2882)). + ### Director 1.11.0 You cannot create usergroups because of invalid property assign_filter ([see](https://github.com/telekom-mms/ansible-collection-icinga-director/issues/228)). diff --git a/meta/runtime.yml b/meta/runtime.yml index 6d1ae61a..96f7fcac 100644 --- a/meta/runtime.yml +++ b/meta/runtime.yml @@ -1,5 +1,5 @@ --- -requires_ansible: '>=2.9.10' +requires_ansible: ">=2.14.0" action_groups: icinga: