Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Logging #21

Merged
merged 11 commits into from
Jul 16, 2024
Merged

Add Logging #21

merged 11 commits into from
Jul 16, 2024

Conversation

esarver
Copy link
Member

@esarver esarver commented Jul 10, 2024

Add logging to the top-level, FOSS kic binaries. Further logging can be added in dependencies at will.

@esarver esarver self-assigned this Jul 10, 2024
Copy link

github-actions bot commented Jul 10, 2024

Code Coverage

Package Line Rate Health
kic-discover/src/lib.rs 0%
kic/src/main.rs 0%
kic-discover/src/instrument_discovery/mod.rs 0%
instrument-repl/src/resources/mod.rs 100%
instrument-repl/src/instrument.rs 86%
kic-discover/src/usbtmc/mod.rs 0%
kic-discover/src/ethernet/mod.rs 0%
instrument-repl/src/state_machine.rs 63%
kic/src/process.rs 0%
instrument-repl/src/tsp_error.rs 0%
instrument-repl/src/error.rs 0%
kic-discover/src/main.rs 0%
instrument-repl/src/repl.rs 0%
kic/src/error.rs 0%
Summary 19% (295 / 1550)

@esarver esarver marked this pull request as ready for review July 12, 2024 18:37
@esarver esarver requested a review from a team as a code owner July 12, 2024 18:37
Copy link
Contributor

@jharajeev55 jharajeev55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@esarver esarver merged commit f7d1780 into main Jul 16, 2024
10 checks passed
@esarver esarver deleted the task/add-logging branch July 16, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants