Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported devices and VISA backends in the readme #170

Merged
merged 13 commits into from
Mar 28, 2024

Conversation

adityakb
Copy link
Contributor

Proposed changes

Please include a summary of the changes and any links to related issues. Please also include relevant motivation and context.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Functionality update (non-breaking change which updates or changes existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CI/CD update (an update to the CI/CD workflows, scripts, and/or configurations)
  • Documentation update (an update to enhance the user experience when reading through the docs)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

Read Me update for TekVISA support and python API validation status.

Signed-off-by: adityakb <[email protected]>
Signed-off-by: adityakb <[email protected]>
@adityakb adityakb requested a review from a team as a code owner March 26, 2024 12:33
@tek-githubbot-1010 tek-githubbot-1010 requested a review from a team March 26, 2024 12:33
u625355
u625355 previously approved these changes Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (49e87e9) to head (9826639).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #170   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          170       170           
  Lines         3804      3804           
  Branches       643       643           
=========================================
  Hits          3804      3804           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Nicholas Felt <[email protected]>
Signed-off-by: Shashank P <[email protected]>
@nfelt14 nfelt14 enabled auto-merge (squash) March 27, 2024 15:51
@nfelt14 nfelt14 disabled auto-merge March 27, 2024 15:51
@nfelt14 nfelt14 changed the title Adityakb/readme update Update supported devices and VISA backends in the readme Mar 27, 2024
@nfelt14 nfelt14 enabled auto-merge (squash) March 27, 2024 15:52
Signed-off-by: adityakb <[email protected]>
auto-merge was automatically disabled March 27, 2024 17:00

Head branch was pushed to by a user without write access

Signed-off-by: adityakb <[email protected]>
Signed-off-by: adityakb <[email protected]>
Update as per review comments.

Signed-off-by: adityakb <[email protected]>
Signed-off-by: adityakb <[email protected]>
@tektronix tektronix deleted a comment from nfelt14 Mar 28, 2024
u625355
u625355 previously approved these changes Mar 28, 2024
nfelt14
nfelt14 previously approved these changes Mar 28, 2024
@nfelt14 nfelt14 dismissed stale reviews from u625355 and themself via 9826639 March 28, 2024 14:44
@nfelt14 nfelt14 enabled auto-merge (squash) March 28, 2024 14:45
@nfelt14 nfelt14 merged commit 434a485 into tektronix:main Mar 28, 2024
38 checks passed
nfelt14 added a commit to nfelt14/tm_devices that referenced this pull request May 2, 2024
* Update README.rst

Read Me update for TekVISA support and python API validation status.

Signed-off-by: adityakb <[email protected]>

* Update CHANGELOG.md

Signed-off-by: adityakb <[email protected]>

* Updated CHANGELOG.md

Co-authored-by: Nicholas Felt <[email protected]>
Signed-off-by: Shashank P <[email protected]>

* Update README.rst

Mentioning TekVISA version 4.2.0.

Signed-off-by: adityakb <[email protected]>

---------

Signed-off-by: adityakb <[email protected]>
Signed-off-by: Shashank P <[email protected]>
Signed-off-by: Nicholas Felt <[email protected]>
Co-authored-by: Shashank P <[email protected]>
Co-authored-by: Nicholas Felt <[email protected]>
Signed-off-by: Nicholas Felt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants