Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not present discover phase name as a part of test name #2713

Open
janhavlin opened this issue Feb 27, 2024 · 1 comment · May be fixed by #2885
Open

Do not present discover phase name as a part of test name #2713

janhavlin opened this issue Feb 27, 2024 · 1 comment · May be fixed by #2885
Assignees
Labels
step | discover Stuff related to the discover step
Milestone

Comments

@janhavlin
Copy link
Collaborator

janhavlin commented Feb 27, 2024

When multiple phase are used in the discover step, phase name is presented as a part of the test name. Filtering, however, does support only the real test name, without the prefix.

Example of a discover step defining two named phases which import tests from a remote url:

discover:
  - name: first
    url: ...
    ...
  - name: second
    url: ...
    ...

Both destinations could contain tests named /tests/one and /tests/two, and currently, tmt presents the discovered tests including the phase name:

/first/tests/one
/first/tests/two
/second/tests/one
/second/tests/two

Currently, it is not possible to filter by the names as they're presented, running tmt run discover test --name /first/tests/one would not return anything as the test name is actually just /tests/one.

As discussed, the phase name should be distinguished from the test name:

first::/tests/one
first::/tests/two
second::/tests/one
second::/tests/two

On the command line, using the phase name will be allowed when filtering tests by name:

tmt run test --name "first::/tests/first"

Additinonally, the discover phase name should be stored in the tests.yaml (already) and results.yaml (tbd).

Encountered in https://redhat-internal.slack.com/archives/C03BRN71JAF/p1708424104910169.

@janhavlin janhavlin added enhancement step | discover Stuff related to the discover step labels Feb 27, 2024
@psss psss added this to the 1.33 milestone Mar 1, 2024
@happz
Copy link
Collaborator

happz commented Mar 26, 2024

Be aware of related issue #2768

@janhavlin janhavlin linked a pull request Apr 24, 2024 that will close this issue
8 tasks
@janhavlin janhavlin modified the milestones: 1.33, 1.34 Apr 29, 2024
@happz happz modified the milestones: 1.34, 1.35 Jun 11, 2024
@janhavlin janhavlin linked a pull request Jun 25, 2024 that will close this issue
8 tasks
@janhavlin janhavlin modified the milestones: 1.35, 1.36 Jul 30, 2024
@janhavlin janhavlin modified the milestones: 1.36, 1.37 Aug 27, 2024
@thrix thrix modified the milestones: 1.37, 1.38 Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
step | discover Stuff related to the discover step
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants