Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Enable using of adjust at any level #157

Open
kkaarreell opened this issue Mar 23, 2022 · 1 comment
Open

[RFE] Enable using of adjust at any level #157

kkaarreell opened this issue Mar 23, 2022 · 1 comment
Labels
context discuss enhancement New feature or request

Comments

@kkaarreell
Copy link
Contributor

In my current test plan I am using adjust to modify both prepare and discover
https://github.com/keylime/keylime/blob/master/packit-ci.fmf

It is still quite short and therefore readable but it seems to me that with more conditions in adjust block things would become a bit more messy. I think it would be more user friendly if I could have one adjust inside the prepare step and another adjust in discover.

@kkaarreell
Copy link
Contributor Author

So it could be more like this:

/e2e:
  summary: run keylime e2e tests

  prepare:
    how: shell
    script: 
     - ln -s $(pwd) /var/tmp/keylime_sources

    adjust:
     - when: distro == centos-stream-9
       script+: 
        - yum -y install https://dl.fedoraproject.org/pub/epel/epel-release-latest-9.noarch.rpm

     - when: distro == centos-stream-8
       script+: 
        - yum -y install https://dl.fedoraproject.org/pub/epel/epel-release-latest-8.noarch.rpm

  discover:
    how: fmf
    url: https://github.com/RedHat-SP-Security/keylime-tests
    ref: main
    test: 
     - /setup/configure_tpm_emulator
     - /setup/install_upstream_keylime
     - /setup/enable_keylime_coverage
     - /functional/basic-attestation-on-localhost
     - /setup/generate_coverage_report

    adjust:
     - when: distro != fedora-35
       test-:
        - /setup/enable_keylime_coverage
        - /setup/generate_coverage_report

  execute:
    how: tmt

@lukaszachy lukaszachy added enhancement New feature or request context discuss labels Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context discuss enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants