Mm 005 header v2 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kiran-R-K
requested changes
Jul 31, 2024
src/App.tsx
Outdated
| function App() { | ||
| return ( | ||
| <div className="App"> | ||
| <Router> | ||
| <h1>MarsioKart</h1> | ||
| <div><Header/></div> |
There was a problem hiding this comment.
If you remove the <div>s from this line and just have <Header/> it will be easier for a screen reader to see what is happening and translate it - please can you do that?
src/Hamburgerbutton.scss
Outdated
There was a problem hiding this comment.
This is looking great and is nice and clear - in order to prevent the src folder from being too full of separate files (and therefore harder to read through) please can you create a Hamburgerbutton folder and put this file and Hamburgerbusston.tsx in it
src/header.tsx
Outdated
There was a problem hiding this comment.
As above - please can you also create a Header folder and put this file in it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes -
added a button in the style of hamburger in header
when button is clicked, outputs msg to console log
added unit test for onclick
Screenshots - for changes to the UI
Things to Check