Mm 104 selection buttons and display image preview #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6784c74.
Co-authored-by: Claudia Giancola <[email protected]>
Kiran-R-K
requested changes
Aug 2, 2024
src/utils/getDates.ts
Outdated
There was a problem hiding this comment.
I don't think this files is doing anything - can it be removed?
| const [myPreviewImage, setMyPreviewImage] = useState<PictureOfDay | null>(null); | ||
| const [birthday, setBirthday] = useState(''); | ||
|
|
||
| const handleRandomButtonClick = async () => { |
There was a problem hiding this comment.
This doesn't seem to be running correctly but I don't think there's time to fix it so let's remove the random button from the page
dorothyynwong
deleted the
mm-104-selection-buttons--and-display-image-preview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes - what did you do
Added component PreviewImage and inside of it we created three inputs (Birthday form + today's date button + random button) that, if clicked, allow the relative image to be displayed.
We updated Home.tsx to include this PreviewImage component and show the relative inputs and result image.
In App.scss we implemented a very simple styling of the chosen preview image.
Things to Check