Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added question iteration. #20

Merged
merged 8 commits into from
Aug 1, 2024
Merged

added question iteration. #20

merged 8 commits into from
Aug 1, 2024

Conversation

bobbybwoy
Copy link
Collaborator

Implemented navigating through all questions

Screenshots - for changes to the UI

image

image

Things to Check

  • Have all the requirments of your ticket have been met
  • Have you added tests if needed for your ticket - no tests performed
  • Are all the tests passing - n/a

Copy link
Contributor

@Kiran-R-K Kiran-R-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good job on this one - especially given the fact you also scoped the ticket yourselves


const question = questions[Math.floor(Math.random() * questions.length)];
export function QuestionDisplay(props: QuestionDisplayProp) {
// const questions = getQuizQuestions();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving old code in as comments creates a risk of confusion when it comes to re-reading/updating the code.
please remove these

<input type="radio" name="answer" id="radio-button1" value="0" /> {props.question.answers[0].answer} <br/>
<input type="radio" name="answer" id="radio-button2" value="1" /> {props.question.answers[1].answer} <br/>
<input type="radio" name="answer" id="radio-button3" value="2" /> {props.question.answers[2].answer} <br/>
{/* <button type="submit" className="submit-answer" onClick={() => updateCurrentIndex() }>Submit</button> */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above please can this comment be removed from this PR

@sun-amy sun-amy merged commit 547e64f into main Aug 1, 2024
1 check passed
@sun-amy sun-amy deleted the mm-307-question-iteration branch August 1, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants