added logo to the header #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kiran-R-K
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
This looks really good - I also appreciate that you've taken the time to do some clean up and improvement of file structuring around the app.
A couple of points:
- I have left an optional comment, I intend to approve either way but it's up to you two if you want to action it or not - see how you feel about it.
- I'm going to approve this but it's not mergeable yet because the pipeline has failed so once you push a fix for that you will be able to merge it without it needing another review. (I'm happy to talk through what the error is and the fix for it if you want just pop me a message).
- Moving those files into folders could to lead to some clashes with other code (that doesn't mean it's not a good choice - it is, but it's one that requires extra team communication) I would suggest sending a message in the mars-mission channel letting everyone know what you moved and where so that they know to expect this change when they merge into main.
Let me know if you have any questions
| @@ -24,7 +24,7 @@ | |||
| work correctly both with client-side routing and a non-root public URL. | |||
| Learn how to configure a non-root public URL by running `npm run build`. | |||
| --> | |||
| <title>React App</title> | |||
| <title>Marsio Kart</title> | |||
There was a problem hiding this comment.
I think this file was accidentally left in your branch form another ticket - you can delete it from this branch so it doesn't get merged in with this work
There was a problem hiding this comment.
As above, this looks like this file has snuck in from another branch - you can delete it from this branch so it doesn't get merged in with this work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the logo from the public folder into src/ImageAssets folder to be accessible, then added the logo to the header.
We also moved the header.tsx file into its own folder, and the Hamburgerbutton.tsx and the Hamburgerbutton.scss into their own folder.
Additionally we changed the tab title to Marsio Kart.
Things to Check