Mm 006 creation api functions #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rogress Co-authored-by: Dorothy Wong <[email protected]>
…rogress Co-authored-by: Dorothy Wong <[email protected]>
…rogress Co-authored-by: Dorothy Wong <[email protected]>
…rogress Co-authored-by: Dorothy Wong <[email protected]>
Kiran-R-K
requested changes
Jul 31, 2024
.env.template
Outdated
There was a problem hiding this comment.
I think you accidentally deleted this file - please can you recreate it - as it's needed for the codebase
src/App.tsx
Outdated
| import './App.scss'; | ||
| import Home from './Home/Home'; | ||
| // line below is just an example of what to import to use the DisplayPictureOfDay function |
There was a problem hiding this comment.
Please remove these comments and the the before merging - they might be confusing for some people
src/images/DisplayPicture.tsx
Outdated
|
|
||
| const pictureData = await fetchAPI("https://api.nasa.gov/planetary/apod?api_key="); | ||
|
|
||
| // test picture data for when the API requests have reached their limit: |
There was a problem hiding this comment.
Please remove this from this PR as it's not for production.
src/images/DisplayPicture.tsx
Outdated
|
|
||
| return myPictureData; | ||
|
|
||
| // example of how to pick specific properties |
There was a problem hiding this comment.
please remove these comments from this review for clarity
…ate 3.remove test data
Kiran-R-K
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
##Description of changes - what did you do
added scripts:
script 1: utils/fetchData.ts to fetch API.
This function is reusable.
We implemented the use of the .env variable for the apiKey.
input:
a string for API url (without the final part containing the key) e.g. "https://api.nasa.gov/planetary/apod?api_key="
need a .env file in the root directory. inside the .env file, it should be something like this REACT_APP_NASA_API_KEY=""
output:
if there is error, return an error page. otherwise, return the JSON got from the API.
script 2: image/DisplayPicture.tsx to call fetchData
output (needs more work):
Option 1: if you return a React component (return (<>....</>) you can display specific properties of the Image of The Day.
You can render it as , the example can be found in App.tsx
Option 2: you can return the myPictureData instead (but we still are unsure about how to visualize it).
It will probably need another function so that the developer can choose what property to display accordingly to their need
##Things to Check
[ok ] Have all the requirements of your ticket have been met
[n/a] Have you added tests if needed for your ticket
[n/a ] Are all the tests passing