Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uberjars don't set multi-release when appropriate #2744

Closed
dpsutton opened this issue May 11, 2021 · 1 comment
Closed

uberjars don't set multi-release when appropriate #2744

dpsutton opened this issue May 11, 2021 · 1 comment

Comments

@dpsutton
Copy link

dpsutton commented May 11, 2021

Describe the bug
Making an uberjar when one of your dependencies is a multi-release jar does not mark your jar as multi-release

To Reproduce

(defproject aproject "0.0.1"
  :dependencies     [[org.apache.logging.log4j/log4j-core "2.13.3"]
                     [org.apache.logging.log4j/log4j-api "2.13.3"]])

lein uberjar

log4j is a multi-release jar which includes code specific to different jvm version. When

Actual behavior
The manifest file does not include Multi-Release: true

Expected behavior
The manifest file includes this entry to correctly mark the jar as multi-release.

Workaround
specify

  :manifest {"Multi-Release" true}

in project.clj

@technomancy
Copy link
Owner

This seems like a duplicate of #2743.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants