-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SelectField] Standardize with MenuField / general improvements #132
Comments
The first task is also in the Road to v1 issue |
Task 1 and 3 resolved via #127. |
@willnationsdev Tagging you here if you're interested in knocking out these, but don't feel like you have to. |
Got a PR, but even with the icons added back in, the blue coloration they had before on the docs page is now gone. I'd bet there're styles somewhere in the docs that need to be adjusted. Cause you wouldn't wanna make a change like that to the component itself or to the theme that applies to everyone's usage of the SelectField's MenuItems - you just want the docs page. But the docs page didn't appear to have Tailwind classes is was merging in via attributes, so idk where those styles came from. |
Extracted from PR #130
label
instead ofname
by default (can still be overwritten byoptionText()
, maybe we call thisoptionLabel()
, or maybe we require the data to be processed ahead of time and remove this andoptionValue()
icon
prop to MenuItem like MenuField<SelectField icon={...} />
based on the selected<MenuItem icon={...} />
?activeOptionIcon
or something)The text was updated successfully, but these errors were encountered: