Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SelectField] Standardize with MenuField / general improvements #132

Closed
4 tasks done
techniq opened this issue Nov 14, 2023 · 4 comments
Closed
4 tasks done

[SelectField] Standardize with MenuField / general improvements #132

techniq opened this issue Nov 14, 2023 · 4 comments
Milestone

Comments

@techniq
Copy link
Owner

techniq commented Nov 14, 2023

Extracted from PR #130

  • Use same Options type instead of any
    • Will use label instead of name by default (can still be overwritten by optionText(), maybe we call this optionLabel(), or maybe we require the data to be processed ahead of time and remove this and optionValue()
  • Pass icon prop to MenuItem like MenuField
  • Should we update the <SelectField icon={...} /> based on the selected <MenuItem icon={...} />?
    • Add a prop to opt-in to this functionality (activeOptionIcon or something)
    • Require the user to do this (like the SelectField example currently does.
  • Fix clicking on Chevon icon/button to close (re-toggles open) ([SelectField] Clicking chevron arrow re-opens menu #93)
@techniq
Copy link
Owner Author

techniq commented Nov 14, 2023

The first task is also in the Road to v1 issue

@techniq
Copy link
Owner Author

techniq commented Dec 19, 2023

Task 1 and 3 resolved via #127.

@techniq techniq changed the title [SelectField] Standardize with MenuField [SelectField] Standardize with MenuField / general improvements Dec 19, 2023
@techniq
Copy link
Owner Author

techniq commented Dec 19, 2023

@willnationsdev Tagging you here if you're interested in knocking out these, but don't feel like you have to.

@willnationsdev
Copy link
Contributor

Got a PR, but even with the icons added back in, the blue coloration they had before on the docs page is now gone. I'd bet there're styles somewhere in the docs that need to be adjusted. Cause you wouldn't wanna make a change like that to the component itself or to the theme that applies to everyone's usage of the SelectField's MenuItems - you just want the docs page. But the docs page didn't appear to have Tailwind classes is was merging in via attributes, so idk where those styles came from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants