Avoid uninitialized variable error in Duration component with Svelte 5

techniq · Jul 31, 2024 · d766716 · d766716
1 parent e3bbb08
commit d766716
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/.changeset/chilly-donuts-brush.md b/.changeset/chilly-donuts-brush.md
@@ -0,0 +1,5 @@
+---
+'svelte-ux': patch
+---
+
+Avoid uninitialized variable error in Duration component with Svelte 5
diff --git a/packages/svelte-ux/src/lib/components/Duration.svelte b/packages/svelte-ux/src/lib/components/Duration.svelte
@@ -20,8 +20,9 @@
 
   const settingsClasses = getComponentClasses('Duration');
 
-  function getDelay() {
-    const newDuration = getDuration(start, end ?? $timer, duration);
+  function getDelay(useTimer = true) {
+    const endTime = end ?? (useTimer ? $timer : null);
+    const newDuration = getDuration(start, endTime, duration);
 
     const unitsMoreThanSeconds = [
       newDuration?.years,
@@ -43,7 +44,8 @@
   }
 
   const timer = timerStore({
-    delay: getDelay(),
+    // Pass false to avoid referencing `timer` before it exists
+    delay: getDelay(false),
     disabled: end != null,
     onTick: () => {
       // Update delay based on display duration