Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Net/persist): 纠正错误处理方式，拿掉 err 是 Observable 的假设 #663

Open
wants to merge 1 commit into
base: release
Choose a base branch
from
Open

fix(Net/persist): 纠正错误处理方式，拿掉 err 是 Observable 的假设 #663

wants to merge 1 commit into from

Conversation

chuan6
Copy link
Contributor

@chuan6 chuan6 commented Jul 29, 2019 •
edited
Loading

...err 是 Observable 的合理可能只存在于有地方抛错时抛的是 Observable
的情况；这不符合正常操作习惯。（已经在 #668 中由于导致测试失败提前调整）

  • 确认当前 persist 方法里可能遇到的报错对象有哪些？
  • 补充单元测试

@chuan6
fix(Net/persist): 纠正错误处理方式，拿掉 err 是 Observable 的假设
11a8ab8 
...err 是 Observable 的合理可能只存在于有地方抛错时抛的是 Observable
的情况；这不符合正常操作习惯。
@chuan6 chuan6 added the bug label Jul 29, 2019
@chuan6 chuan6 requested a review from 2eha0 July 29, 2019 10:21
@chuan6 chuan6 self-assigned this Jul 29, 2019
@chuan6
Copy link
Contributor Author

chuan6 commented Jul 29, 2019

@2eha0 这个修正我还没处理完，等上面两个 todo 里的东西处理好了，我找你帮忙 review 一下哈，谢谢 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2eha0 2eha0 Awaiting requested review from 2eha0

Assignees

@chuan6 chuan6

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chuan6