-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logged tunable number to coppercore #73
Comments
is 2025 working yet, or should I branch off of the 2024 version? |
Just branch off of coppercore main (2025) - I think it should be good |
@jkleiber Hello! I'm trying to test out loggedtunable in high key but it's not working- Aiden helped me publish to local maven, what is the implementation string after that? thank you! |
@minhnguyenbhs it should be the exact same string but with whatever version you're publishing to local |
@minhnguyenbhs Okay I tested out the exact issue you were describing earlier, it looks like the import is actually broken by the vision import and not by the controls import itself. If you remove the vision import from the controls build.gradle (it built fine without it for me?) and then republish, you should be able to import it from the robot code repo. |
@minhnguyenbhs should there be a PR for this? Looks like you got it workimg on high key |
Sorry I didn't actually get it working with highkey since I branched off of 2025 and it doesn't work with 2024 code- but it is working with elevator code now! |
@jkleiber in order to merge elevator I'll have to publish a new release for coppercore that includes this feature. I realize that I forgot to change the version in gradle.properties last time, which is probably why it failed to publish. Should we go ahead and change that version string in this branch so it can be published right after merge? |
We can go to 0.2-beta just for sake of consistency |
@aidnem hii is the non beta version of advantagekit out yet? I can't find it, and the Robot.java on my testing branch of the elevator code is still really broken- thanks! |
@minhnguyenbhs it looks like it was released yesterday: https://github.com/Mechanical-Advantage/AdvantageKit/releases/tag/v4.0.0 We should upgrade to this version, but just note that we should expect to need to update again once photonvision is released |
@jkleiber @minhnguyenbhs wpilib_interface could be updated at least along with parameter tools, it doesn't rely on photon vision. Then we could just leave vision to be updated once photon vision has a release |
@linglejack06 I agree 100% |
@minhnguyenbhs how close is this to being done? |
moved to parameter_tools, tested with aiden's elevator branch! |
Summary
The proof of concept logged tunable number was implemented here: team401/high-key-2024#82
Let's get this added to coppercore
Work Required
The text was updated successfully, but these errors were encountered: