Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework vision #29

Open
linglejack06 opened this issue Nov 5, 2024 · 8 comments · May be fixed by #69
Open

rework vision #29

linglejack06 opened this issue Nov 5, 2024 · 8 comments · May be fixed by #69
Assignees

Comments

@linglejack06
Copy link
Contributor

Summary: create a useful vision system across years

  • read Photon Vision docs thoroughly
  • add basic example and test
  • if needed, add more advanced standard deviations and pose rejections (after testing basic)
@linglejack06
Copy link
Contributor Author

@aidnem youre just a placeholder here, just figured i would start creating issues while i had time

@aidnem
Copy link
Contributor

aidnem commented Nov 6, 2024

@linglejack06 Sounds good. I've been reading photon docs and I will continue so I can gladly take some of the issues and I can also create some.
Not sure if you saw but the retro doc is on the controls drive so we should create a comment on each item of the doc that we create an issue for so that we don't create duplicate tickets.

@aidnem
Copy link
Contributor

aidnem commented Nov 7, 2024

I'm going to break this issue down into smaller issues so we can work more incrementally

@aidnem
Copy link
Contributor

aidnem commented Nov 8, 2024

Created and worked on #30

@jkleiber jkleiber added this to the 2025 MVP Features milestone Nov 19, 2024
@linglejack06
Copy link
Contributor Author

@jkleiber @aidnem why have we never tried using limelight rather than photon vision? a lot of the code seems simpler to incorporate

@jkleiber
Copy link
Member

@linglejack06 a single limelight costs $400 while we can get 4 cameras and a beelink for a similar price. The cameras on the limelight are very similar to the ones we have as well

Theoretically we should be able to get better coverage with multiple cameras. The advantage of limelight is that they do most of the work for users, which is why it is more expensive and why the code is easier

@linglejack06
Copy link
Contributor Author

linglejack06 commented Nov 23, 2024 via email

@avidraccoon
Copy link
Contributor

They also sell one for 200

@jkleiber jkleiber assigned linglejack06 and unassigned aidnem Dec 10, 2024
@linglejack06 linglejack06 linked a pull request Dec 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants