Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TuneG, TuneS, and TuneV #25

Open
aidnem opened this issue Oct 9, 2024 · 4 comments
Open

Add TuneG, TuneS, and TuneV #25

aidnem opened this issue Oct 9, 2024 · 4 comments
Assignees

Comments

@aidnem
Copy link
Contributor

aidnem commented Oct 9, 2024

Scope
Add the TuneG, TuneS, and TuneV classes from 2024 so that we can use Tunable more effectively.

@aidnem aidnem self-assigned this Oct 9, 2024
@aidnem
Copy link
Contributor Author

aidnem commented Oct 9, 2024

@jkleiber do you think it's okay to put these in wpi-interface even though technically they should be under control? They depend on WPI and I want to keep them in the right bucket if possible. Perhaps we could allow multiple submodules in wpi interface or something?

@jkleiber
Copy link
Member

jkleiber commented Oct 9, 2024

@aidnem I think this is a perfectly acceptable use of wpi_interface because these commands are interfacing the generic controls Tunable with the WPILib

@aidnem
Copy link
Contributor Author

aidnem commented Oct 9, 2024

I'm having some issues importing other packages while writing code in wpi interface. Perhaps we could look into this tomorrow as it should be an otherwise easy port.

@aidnem aidnem linked a pull request Oct 9, 2024 that will close this issue
@aidnem
Copy link
Contributor Author

aidnem commented Nov 12, 2024

Now that I know how to use wpilib imports again I can finally finish this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants