Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docusaurus: multiple nav landmarks need labels. #90

Open
7mary4 opened this issue Nov 16, 2021 · 0 comments
Open

Docusaurus: multiple nav landmarks need labels. #90

7mary4 opened this issue Nov 16, 2021 · 0 comments
Labels

Comments

@7mary4
Copy link
Contributor

7mary4 commented Nov 16, 2021

Expected Behavior

People using the landmarks navigation should know the difference between multiple navigation landmarks. This is done with the aria-label attribute.

Current Behavior

The tutorial outline has an aria-label, but not the main navigation

Steps to reproduce

Please provide detailed steps for reproducing the issue.

  1. load page
  2. run Axe or similar test
  3. there should be no errors for duplicate/unlabeled landmarks

Suggested code update

<nav class="navbar navbar--fixed-top" aria-label="Main">
It would be good to update the outline label
Current
<nav class="pagination-nav docusaurus-mt-lg" aria-label="Docs pages navigation">
Updated
<nav class="pagination-nav docusaurus-mt-lg" aria-label="Tutorial pages">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants