Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-AMENDMENT_SEX_STANDARDIZED #284

Open
ArthurChapman opened this issue Feb 9, 2024 · 15 comments
Open

TG2-AMENDMENT_SEX_STANDARDIZED #284

ArthurChapman opened this issue Feb 9, 2024 · 15 comments
Labels
Amendment Conformance CORE TG2 CORE tests OTHER Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 VOCABULARY

Comments

@ArthurChapman
Copy link
Collaborator

ArthurChapman commented Feb 9, 2024

TestField Value
GUID 33c45ae1-e2db-462a-a59e-7169bb01c5d6
Label AMENDMENT_SEX_STANDARDIZED
Description Proposes an amendment to the value of dwc:sex using the bdq:sourceAuthority.
TestType Amendment
Darwin Core Class dwc:Occurrence
Information Elements ActedUpon dwc:sex
Information Elements Consulted
Expected Response EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL PREREQUISITES_NOT_MET if dwc:sex is bdq:Empty; AMENDED the value of dwc:sex if it can be unambiguously matched to a term in the bdq:sourceAuthority; otherwise NOT_AMENDED
Data Quality Dimension Conformance
Term-Actions SEX_STANDARDIZED
Parameter(s) bdq:sourceAuthority
Source Authority bdq:sourceAuthority default = "GBIF Sex Vocabulary" [https://api.gbif.org/v1/vocabularies/Sex]} {"dwc:sex vocabulary API" [https://api.gbif.org/v1/vocabularies/Sex/concepts]}
Specification Last Updated 2024-03-25
Examples [dwc:sex="f": Response.status=AMENDED, Response.result=dwc:sex="Female", Response.comment="dwc:sex found in the bdq:sourceAuthority"]
[dwc:sex="x": Response.status=NOT_AMENDED, Response.result="", Response.comment="dwc:sex not found in the bdq:sourceAuthority"]
Source TG2
References
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes For reference, a list of synonyms for dwc:sex values can be found at https://registry.gbif.org/vocabulary/Sex/concepts.
@ArthurChapman ArthurChapman added TG2 Amendment OTHER Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT VOCABULARY Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. Conformance labels Feb 9, 2024
@ymgan
Copy link
Collaborator

ymgan commented Feb 12, 2024

I saw in #286

References: GBIF (2021). Darwin Core Nomenclatural Type Status Vocabulary http://rs.gbif.org/vocabulary/gbif/type_status

so should this also be in the References? https://rs.gbif.org/vocabulary/gbif/sex.xml

@chicoreus
Copy link
Collaborator

Noting that the current GBIF sex vocabulary is very animal centric.

@ArthurChapman
Copy link
Collaborator Author

Thanks @ymgan - added. @chicoreus - agreed

@ymgan
Copy link
Collaborator

ymgan commented Feb 22, 2024

oh, seems like GBIF is working on the vocabularies for sex at the moment gbif/vocabulary#83

@CecSve
Copy link

CecSve commented Feb 22, 2024

@ymgan yes, we are updating vocabularies and moving them from enums to the vocabulary server, eventually. This is also the case for Type Status btw. The updates are to improve the mapping of hidden values provided by publishers. The sex vocabulary is very animal centric since most data comes from eBird @chicoreus - but please, if you know of any sources that cover concepts suitable for other groups, then we should be able to include them.

@ArthurChapman ArthurChapman added Immature/Incomplete A test where substantial work is needed to develop the specification to the point where the test ca and removed Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. labels Feb 22, 2024
@ArthurChapman
Copy link
Collaborator Author

I have changed this to Immature/Incomplete pending the Vocabulary by GBIF.

@CecSve
Copy link

CecSve commented Feb 27, 2024

The vocabulary (v1) is now uploaded to the vocabulary server: https://registry.gbif.org/vocabulary/Sex and can be accessed by the vocabulary API (as Marie mentioned): https://techdocs.gbif.org/en/openapi/v1/vocabulary.

@chicoreus
Copy link
Collaborator

chicoreus commented Feb 28, 2024 via email

@ymgan
Copy link
Collaborator

ymgan commented Mar 20, 2024

Similar to what @Tasilee mentioned in #277, #276, seems like GBIF API for Sex vocab is live
https://api.gbif.org/v1/vocabularies/Sex/concepts

@CecSve
Copy link

CecSve commented Mar 20, 2024

This may not affect your decision but just wanted to highlight that the vocabularies (sex, geodeticdatum, kingdom, month, and taxonrank) are not yet used in interpretation in GBIF. We have to upload a couple more vocabularies before we initiate the process of reinterpretation for all occurrences.

@Tasilee
Copy link
Collaborator

Tasilee commented Mar 20, 2024

Updated Source Authority to reflect new GBIF vocabulary. Does this imply this test could be CORE or Supplementary?

@tucotuco
Copy link
Member

Updated Source Authority to reflect new GBIF vocabulary. Does this imply this test could be CORE or Supplementary?

I don't believe that where the vocabulary comes from is a criterion for CORE. It is a separate issue.

@ArthurChapman ArthurChapman added CORE TG2 CORE tests and removed Immature/Incomplete A test where substantial work is needed to develop the specification to the point where the test ca labels Mar 25, 2024
@ArthurChapman
Copy link
Collaborator Author

Changed to CORE following updating of GBIF Vocabulary, making a vocabulary available. This was the only reason it was made Immature/Incomplete earlier.

@ArthurChapman
Copy link
Collaborator Author

Note deleted as it referred to Supplementary test which no longer applies

@Tasilee
Copy link
Collaborator

Tasilee commented Apr 16, 2024

Changed Source Authority from

bdq:sourceAuthority default = "Darwin Core sex" {[https://dwc.tdwg.org/list/#dwc_sex]} {dwc:sex vocabulary API [https://api.gbif.org/v1/vocabularies/Sex/concepts]}

to

bdq:sourceAuthority default = "GBIF Sex Vocabulary" [https://api.gbif.org/v1/vocabularies/Sex]} {"dwc:sex vocabulary API" [https://api.gbif.org/v1/vocabularies/Sex/concepts]}

chicoreus added a commit to FilteredPush/rec_occur_qc that referenced this issue Jul 27, 2024
…, added to unit tests. Added implementations for core tests tdwg/bdq#284 tdwg/bdq#275 and tdwg/bdq#276 along with default methods and unit tests.
chicoreus added a commit to FilteredPush/rec_occur_qc that referenced this issue Jul 29, 2024
chicoreus added a commit to FilteredPush/rec_occur_qc that referenced this issue Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Amendment Conformance CORE TG2 CORE tests OTHER Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 VOCABULARY
Projects
None yet
Development

No branches or pull requests

6 participants