- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support emojis #73
Comments
Hey @oliverpool , that is a great idea! There are two separate things that come to my mind:
Both should happen at some point, but the first is far more useful and versatile and can in the meantime be an alternative for the second. Parsing SVGs in SFNT fonts is a lot of work. However, If you want emoticon support soon, I suggest you create your own branch for now, or wait for the new branch to be merged. You could also push to master now, but there's little gain as the new branch will merge over your changes! |
All right, I will maintain my own branch for now (master...oliverpool:bilderbrief) Feel free to ping me when the develop branch is finalized, so that I can check if everything still works fine for my usecases and look how I can integrate the emojis back (no hurry - it works fine for now :) |
I've incorporated this issue in the new roadmap from where it will be tracked: #74 |
I'm interested in using this package (which is awesome by the way!) for rendering emojis inline with text and came across this issue where it seems that the groundwork has already been started to support this. Is there any appetite to get the changes merged into the upstream? Thanks |
Hi Wei, this has already been merged and you can insert images or any
"canvas" online with text, please see the documentation of the RichText
struct ;-)
…On Fri, Sep 1, 2023, 20:32 Wei Zhong Tan ***@***.***> wrote:
I'm interested in using this package (which is awesome by the way!) for
rendering emojis inline with text and came across this issue where it seems
that the groundwork has already been started to support this. Is there any
appetite to get the changes merged into the upstream? Thanks
—
Reply to this email directly, view it on GitHub
<#73 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKOGHT2SVX3RILAJWU55OTXYIS33ANCNFSM4XNDQC6A>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
For your information, see
https://github.com/tdewolff/canvas/wiki/Fonts-&-Text#images-paths-and-formulas-between-text
…On Sat, Sep 2, 2023, 07:52 Taco de Wolff ***@***.***> wrote:
Hi Wei, this has already been merged and you can insert images or any
"canvas" online with text, please see the documentation of the RichText
struct ;-)
On Fri, Sep 1, 2023, 20:32 Wei Zhong Tan ***@***.***> wrote:
> I'm interested in using this package (which is awesome by the way!) for
> rendering emojis inline with text and came across this issue where it seems
> that the groundwork has already been started to support this. Is there any
> appetite to get the changes merged into the upstream? Thanks
>
> —
> Reply to this email directly, view it on GitHub
> <#73 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABKOGHT2SVX3RILAJWU55OTXYIS33ANCNFSM4XNDQC6A>
> .
> You are receiving this because you modified the open/close state.Message
> ID: ***@***.***>
>
|
I would like to render emojis embedded in the text.
I have made a proof-of-concept that works like this:
1f3c3-200d-2640-fe0f.png
=> 🏃♀️)RichText
to recognize the supported emojis from the input text (inRichText.Add
)RichText.ToText
(and replace its text with""
to prevent being it renderer as text)Since the emoji influence the position of the letters (computed in
RichText
), this requires a modification of the core (andText
has unexported fields, so a 3-rd party package can't work).However the rendering of the emojis does not have to be in the core (only the identification of the "supported emojis" must be integrated) - so no dependency on twemoji.
Would you consider such an addition to the library or do you think that this is way out of scope?
I can show you in a draft PR if you want to take a closer look at the modifications that I made.
Background: I am using this project for a small german startup (https://www.bilderbrief.de/) and my customers would ❤️ to send emojis 😉
The text was updated successfully, but these errors were encountered: