Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no deprecation warning if custom_parent_classes==[] #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brchristian
Copy link
Contributor

As mentioned in #89 (comment) and in some of the issues like #91, the current master version is issuing unnecessary deprecation warnings when custom_parent_classes == [].

Merging #89 will make this PR moot, because that refactors away the custom_parent_classes object entirely. That would be my personal recommendation.

But, if there is hesitation to merge #89 for whatever reason, then we can at least merge this in the meantime and remove some of those unnecessary warnings. We could then aim to merge #89 at some later point in time.

Copy link

@rafaelfranca rafaelfranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, excellent finding! Thank you for opening the pr.

@Tybot204
Copy link

👍 Would love to see this merged in. My test suite gets spammed with these deprecation messages atm!

@mion
Copy link

mion commented Mar 28, 2017

Same thing here! 👍 Good work, guys.

@cenderin
Copy link

Please merge this in :).

@JerryArns
Copy link

JerryArns commented Sep 23, 2017

Is there a way to pull this into the gem locally and use it?
edit
Change your gem file to the following.
gem 'acts_as_follower', github: 'brchristian/acts_as_follower', :branch => 'patch-1'

@iguanus
Copy link

iguanus commented Apr 4, 2018

Merge, please =)

@kidbombay
Copy link

Merge possible?

@vsppedro
Copy link

Merge please! 👍

@RailsCod3rFuture
Copy link

We still need a merge....But on another note - Please optimize the embedded queries to minimize the the chance of receiving an n+1 query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants