Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Insight] Your project should not contain "FIXME" comments - in public/js/jquery.magnific-popup.js, line 1310 #9

Open
tcheuD opened this issue Sep 20, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@tcheuD
Copy link
Owner

tcheuD commented Sep 20, 2020

in public/js/jquery.magnific-popup.js, line 1310

Tasks comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

                    }
                    item.img = $(img).on('load.mfploader', onLoadComplete).on('error.mfploader', onLoadError);
                    img.src = item.src;

                    // without clone() "error" event is not firing when IMG is replaced by new IMG
                    // TODO: find a way to avoid such cloning
                    if(el.is('img')) {
                        item.img = item.img.clone();
                    }

                    img = item.img[0];

Posted from SymfonyInsight

@tcheuD tcheuD added the bug Something isn't working label Sep 20, 2020
@tcheuD
Copy link
Owner Author

tcheuD commented Sep 20, 2020

This should be moved to vendor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant