Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with filter arguments #69

Open
tbranyen opened this issue May 14, 2015 · 3 comments
Open

Issue with filter arguments #69

tbranyen opened this issue May 14, 2015 · 3 comments
Milestone

Comments

@tbranyen
Copy link
Owner

I tried passing:

{{ property|replace '-' ' ' }}

and the second argument appeared as ', ' instead of ' '

@kadamwhite
Copy link
Collaborator

What's the code of the filter you were using? I have almost the same filter in my application and it seems to be working as-expected

tbranyen added a commit that referenced this issue Aug 25, 2015
Issue with filter arguments
@tbranyen
Copy link
Owner Author

@kadamwhite #74

@kadamwhite kadamwhite modified the milestone: Version 1.0 Aug 25, 2015
@tbranyen
Copy link
Owner Author

The bug is the result of: https://github.com/tbranyen/combyne/blob/master/lib/tree.js#L376-L377

We just need smarter parsing of the arguments. I think the tokenizer is fine, I think the stack is fine, it's just the tree building that is busted.

tbranyen added a commit that referenced this issue Aug 27, 2015
Issue with filter arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants