Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more than github #198

Open
samyfodil opened this issue Jun 28, 2024 · 4 comments
Open

Support more than github #198

samyfodil opened this issue Jun 28, 2024 · 4 comments
Assignees
Labels
high priority High Priority, should be implemented immediatley

Comments

@samyfodil
Copy link
Contributor

Use https://github.com/jfrog/froggit-go so we can support GitHub, Bitbucket Server , Bitbucket Cloud, Azure Repos and GitLab.

Later we need to figure out how to support self-hosted!

@samyfodil samyfodil self-assigned this Jun 28, 2024
@samyfodil samyfodil added the high priority High Priority, should be implemented immediatley label Jun 28, 2024
@mohitsethia
Copy link
Contributor

Hey @samyfodil , this seems to be a good task for me. I understand that you don't have enough time to guide me for this task.
Maybe I can try explaining what I got and see if this is the right thing to do for this issue. I would break the task into 2 to avoid too many changes in the same PR.

  1. We need to add the methods for VCS providers similar to Github here and add receiver methods New(), List(), Get() based on the provider.
    We need to add auth/{{VCS Provider}}/client.go

  2. After adding the client, we can start supporting it in the below places.
    Changes needs to be made in auth/hooks.go for other cases along with github
    & http/dream/options.go & clients/http/vars/go, variable.go, etc to support other providers.

@samyfodil
Copy link
Contributor Author

@mohitsethia this integration is slightly more complex but you can work on it for sure.
We'll need to refactor:

I expect this will be transparent on client side, though some changes might find there way.

@mohitsethia
Copy link
Contributor

I am sorry for the late response. What exactly needs to be refactored? Do you want me to make it extendible so we can easily include other providers?
Wouldn't adding other providers help along with github? auth/bitbucket.go, etc...

@samyfodil
Copy link
Contributor Author

@mohitsethia dm me on discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority High Priority, should be implemented immediatley
Projects
None yet
Development

No branches or pull requests

2 participants