-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request: valkey support #69
Comments
I don't think it's necessary. At least for now. Because valkey and other technologies as a KeyDB are basically drop-in replacements for redis. The taskiq-redis is not affected by this issue, since the underlying library still has an MIT license and can be used without any issue. |
Understandable, it's just that taskiq-redis has a hard dependency on redis-py. The problem that I see in the nearest year or so is compatibility with official redis is going to be less and less of the concern of fork maintainers. Well, I guess we have to wait and see. |
Hi, I second this request. While it may be a drop-in placement for now redis and valkey will most likely diverge. And it seems like ValKey is the alternative that is been pushed forward the most compared to the other redis forks. Since bigger companies are investing into it |
I third this request. At this point (since 20 March 2024), redis is not open source. The valkey-py package can be used as a drop in replacement to redis. Having extra dependencies in the pyproject toml could be a good way to use this same repo. so we have: pip install taskiq-redis[redis]
pip install taskiq-redis[valkey]
pip install taskiq-redis[libvalkey] (to include the libvalkey optional dependency) then include a separate proxy module file to import valkey if available, otherwise fallback onto redis. # redis_proxy.py
try:
import valkey.asyncio as redis
except ImportError:
import redis.asyncio as redis |
As you all probably know, Redis has changed its license, giving major corporations and contributors all the incentive to make a move to Linux Foundation's new project Valkey. So far the migration to
valkey-py
process seems to be quite straightforward, so I wonder, if it would be possible to implement its support.The text was updated successfully, but these errors were encountered: