0.5.53: Airdrop Settings: CTA's appear as greyed out #968
Assignees
Comments
|
Tested on Windows 11,on app version 0.5.58 and this is still an issue |
|
Tested on Windows 11,on app version 0.6.4 and this is still an issue |
|
Tested on Windows 11,on app version 0.6.6 and this is still an issue |
|
Tested on Windows 11, app version 0.6.14 and this is still an issue |
|
Tested on Windows 11, app version 0.6.15 and this is still an issue |
|
Tested on Windows 11, app version 0.6.16 and this is still an issue |
|
hmm on 0.6.16 they're alright for me? (but tbf i'm on mac)
but i've updated the buttons so they look more like buttons (updated in #1070)
|
|
Tested on Windows 11, app version 0.6.17 and still an issue, I however see @shanimal08 comment wrt to fixes so when merged I will check once again and close of if rectified |
brianp
pushed a commit
that referenced
this issue
Nov 18, 2024
Description --- - changed airdrop buttons from text buttons to more obvious looking buttons + style tweaks - prevent updating seed words if no changes were made - checking `isDirty` and only enable button if yes - if `isDirty` but seed words were only removed and pasted back (not changed at all) do nothing - add a confirmation modal if you are about to update the seed words - fixed emoji id address lineheight Motivation and Context --- - #968 - #960 - #943 How Has This Been Tested? --- - locally https://github.com/user-attachments/assets/972c463d-fe09-4d92-86cb-f40b31cab3ed https://github.com/user-attachments/assets/bfced277-00b1-4dfb-89f0-305a405ea2fc <img width="1121" alt="image" src="https://github.com/user-attachments/assets/5669fbf3-8382-4af2-ba89-624621fe3913"> What process can a PR reviewer use to test or verify this change? --- - [ ] check if airdrop settings buttons look properly clickable - [ ] check that seedwords aren't updated if you've not made any changes to them - [ ] check that you are prompted to confirm before updating if you have indeed made changes to the seedwords - [ ] check that the tari address is not smushed Breaking Changes --- - [x] None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
As a user when I view the Airdrop Settings section, I find that the CTA's: "Apply Invite Code" and "Disconnect" appear as greyed out as it is very light
To Reproduce
Pre-conditions:
Steps
Expected behavior
User should see the text visible and clear to the user, not greyed out
Screenshots
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: