Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-release 2024.08.11 #2789

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I prepared everything for a new TARDIS release.


⚠️ WARNING:

This pull request should be auto-merged. Do not merge manually if any check fails.

Instead, disable auto-merge and push your fixes to the pre-release-2024.08.11 branch on tardis-bot/tardis.

$ git remote add tardis-bot [email protected]:tardis-bot/tardis.git
$ git fetch tardis-bot
$ git checkout tardis-bot/pre-release-2024.08.11
$ git add <file_1> <file_2> ...
$ git commit -m "<your_commit_message>"
$ git push tardis-bot HEAD:pre-release-2024.08.11

Once all the checks pass, you can safely merge this pull request manually.

@epassaro epassaro enabled auto-merge (squash) August 11, 2024 00:26
@tardis-bot
Copy link
Contributor Author

*beep* *bop*
Hi human,
I ran ruff on the latest commit (deb7dd1).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

1	B018	[ ] Found useless expression. Either assign it to a variable or remove it.
1	W292	[*] No newline at end of file

Complete output(might be large):

.zenodo.json:1:1: B018 Found useless expression. Either assign it to a variable or remove it.
.zenodo.json:354:2: W292 [*] No newline at end of file
Found 2 errors.
[*] 1 fixable with the `--fix` option.

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.77%. Comparing base (30427ff) to head (deb7dd1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2789      +/-   ##
==========================================
- Coverage   70.32%   69.77%   -0.56%     
==========================================
  Files         203      203              
  Lines       15234    15234              
==========================================
- Hits        10714    10630      -84     
- Misses       4520     4604      +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tardis-bot
Copy link
Contributor Author

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@tardis-bot
Copy link
Contributor Author

*beep* *bop*
Hi human,
I ran benchmarks as you asked comparing master (30427ff) and the latest commit (deb7dd1).
Here are the logs produced by ASV.
Results can also be downloaded as artifacts here.

Significantly changed benchmarks:

All benchmarks:

Benchmarks that have stayed the same:

| Change   | Before [30427ff0] <master>   | After [deb7dd1f]    | Ratio   | Benchmark (Parameter)                                                                                                                        |
|----------|------------------------------|---------------------|---------|----------------------------------------------------------------------------------------------------------------------------------------------|
|          | 7.81±0μs                     | 11.7±0.6μs          | ~1.50   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list(10, 50)                   |
|          | 2.93±0.5μs                   | 3.27±0.4μs          | ~1.11   | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_bad_vpacket                                                |
|          | 1.34±0.4μs                   | 1.48±0.3μs          | ~1.10   | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_line                             |
|          | 2.14±2μs                     | 2.36±1μs            | ~1.10   | transport_montecarlo_estimators_radfield_estimator_calcs.BenchmarkMontecarloMontecarloNumbaPacket.time_update_line_estimators                |
|          | 19.3±5μs                     | 17.1±5μs            | ~0.89   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list(10, 10)  |
|          | 501±100ns                    | 551±100ns           | 1.10    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation                                               |
|          | 17.1±1μs                     | 18.4±5μs            | 1.07    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list(10, 50)  |
|          | 65.9±0.3ms                   | 70.0±3ms            | 1.06    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_rpacket_trackers_to_dataframe(10, 10)                   |
|          | 64.0±0.2ms                   | 67.0±0.4ms          | 1.05    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_rpacket_trackers_to_dataframe(10, 50)                   |
|          | 561±200ns                    | 582±200ns           | 1.04    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation                                       |
|          | 2.68±0ms                     | 2.73±0.01ms         | 1.02    | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('scatter')                                              |
|          | 1.02±0m                      | 1.04±0m             | 1.02    | run_tardis.BenchmarkRunTardis.time_run_tardis_rpacket_tracking                                                                               |
|          | 40.5±30μs                    | 41.3±20μs           | 1.02    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_emission                                                  |
|          | 43.1±30μs                    | 43.8±30μs           | 1.02    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_scatter                                                   |
|          | 39.2±0.04s                   | 39.7±0.07s          | 1.01    | run_tardis.BenchmarkRunTardis.time_run_tardis                                                                                                |
|          | 203±0.03ns                   | 204±0.2ns           | 1.01    | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_intensity_black_body                                                |
|          | 731±7ns                      | 740±0.2ns           | 1.01    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_thomson_scatter                                                |
|          | 25.5±5μs                     | 25.8±5μs            | 1.01    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list(100, 10) |
|          | 7.32±2μs                     | 7.38±2μs            | 1.01    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_volley                                             |
|          | 2.07±0m                      | 2.07±0m             | 1.00    | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_FormalIntegrator_functions                                          |
|          | 7.35±0μs                     | 7.36±0.02μs         | 1.00    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list(10, 10)                   |
|          | 53.3±0.04μs                  | 53.3±0.02μs         | 1.00    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list(100, 10)                  |
|          | 63.7±0.4ms                   | 63.9±0.1ms          | 1.00    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_rpacket_trackers_to_dataframe(100, 50)                  |
|          | 2.57±0.4ms                   | 2.56±0.4ms          | 1.00    | transport_montecarlo_single_packet_loop.BenchmarkTransportMontecarloSinglePacketLoop.time_single_packet_loop                                 |
|          | 48.5±0.02μs                  | 48.2±0.09μs         | 0.99    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list(100, 50)                  |
|          | 64.8±0.09ms                  | 63.7±0.03ms         | 0.98    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_rpacket_trackers_to_dataframe(100, 10)                  |
|          | 1.23±0μs                     | 1.20±0μs            | 0.97    | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_boundary                         |
|          | 6.62±0.8μs                   | 6.44±0.6μs          | 0.97    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket                                                    |
|          | 561±200ns                    | 541±200ns           | 0.96    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation                                         |
|          | 1.85±0.1ms                   | 1.79±0.01ms         | 0.96    | transport_montecarlo_main_loop.BenchmarkTransportMontecarloMontecarloMainLoop.time_montecarlo_main_loop                                      |
|          | 26.6±6μs                     | 25.6±4μs            | 0.96    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list(100, 50) |
|          | 4.08±0.04ms                  | 3.80±0ms            | 0.93    | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('macroatom')                                            |
|          | 3.71±0.6μs                   | 3.42±0.5μs          | 0.92    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_within_shell                                       |

If you want to see the graph of the results, you can check it here

@andrewfullard andrewfullard merged commit 683bdaa into tardis-sn:master Aug 12, 2024
16 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants