Fast Formal Integral #2725
Merged
Fast Formal Integral #2725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2725 +/- ##
==========================================
- Coverage 36.62% 36.56% -0.07%
==========================================
Files 186 186
Lines 14837 14867 +30
==========================================
+ Hits 5434 5436 +2
- Misses 9403 9431 +28 ☔ View full report in Codecov by Sentry. |
andrewfullard
requested changes
Jul 22, 2024
| # first contribution to integration | ||
| # NOTE: this treatment of I_nu_b (given | ||
| # by boundary conditions) is not in Lucy 1999; | ||
| # should be re-examined carefully |
There was a problem hiding this comment.
Want to re-examine now? :D
There was a problem hiding this comment.
Eh, I can take a look back and try to rederive it
…n cuda device objecst
Fast formal integral subbranch
Removed unneccessary branching
small implimentation detail with indexing
added back the z_end
…_integral_subbranch
Fast formal integral subbranch
andrewfullard
approved these changes
Jul 23, 2024
DeerWhale
reviewed
Jul 23, 2024
andrewfullard
previously approved these changes
Jul 23, 2024
Co-authored-by: Jing Lu <[email protected]>
andrewfullard
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Speed up the GPU computation of the formal integral
Type: 🚀
featureThis updates the current GPU implementation of the formal integral to parallelize over both frequency bin and impact parameter.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel