Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for f64? #96

Open
ChristopherRabotin opened this issue Mar 9, 2022 · 1 comment
Open

Support for f64? #96

ChristopherRabotin opened this issue Mar 9, 2022 · 1 comment

Comments

@ChristopherRabotin
Copy link

Hi there,

Is there any interest in supporting f64 in this crate? I am interested in converting a high precision scientific time computation library to no_std, but it requires 64-bit floating point values and a few functions (sin, div_euclid, and rem_euclid). I'd be happy to give it a shot.

Moreover, and maybe that should be a separate issue, using a Pade approximation for the cosine computation might increase the precision of the result if that is desired.

Cheers

@tarcieri
Copy link
Owner

tarcieri commented Mar 9, 2022

Is there any interest in supporting f64 in this crate?

Sure, that'd be great.

using a Pade approximation for the cosine computation might increase the precision of the result if that is desired.

If you'd like to attempt PoCing it, we can examine the precision/performance tradeoffs and determine if it's worth it.

However note that cosine is pretty much the core of the bulk of the trig functionality in this crate and the current approximation is highly optimized, albeit a bit lacking in precision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants