diff --git a/CHANGELOG.md b/CHANGELOG.md index b15b46080..a5cc700ea 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,7 +9,10 @@ Versioning](http://semver.org/spec/v2.0.0.html) except to the first release. ## [Unreleased] ### Added - +- Add err log to `ConnectionPool.Add()` in case, when unable to establish + connection and ctx is not canceled; + also added logs for error case of `ConnectionPool.tryConnect()` calls in + `ConnectionPool.controller()` and `ConnectionPool.reconnect()` ### Changed ### Fixed diff --git a/pool/connection_pool.go b/pool/connection_pool.go index 949b468bc..1c9d85f44 100644 --- a/pool/connection_pool.go +++ b/pool/connection_pool.go @@ -289,6 +289,8 @@ func (p *ConnectionPool) Add(ctx context.Context, instance Instance) error { e.cancel() close(e.closed) return err + } else { + log.Printf("tarantool: connect to %s failed: %s\n", instance.Name, err) } } @@ -1329,7 +1331,9 @@ func (p *ConnectionPool) reconnect(ctx context.Context, e *endpoint) { e.conn = nil e.role = UnknownRole - p.tryConnect(ctx, e) + if err := p.tryConnect(ctx, e); err != nil { + log.Printf("tarantool: reconnect to %s failed: %s\n", e.name, err) + } } func (p *ConnectionPool) controller(ctx context.Context, e *endpoint) { @@ -1417,7 +1421,10 @@ func (p *ConnectionPool) controller(ctx context.Context, e *endpoint) { // Relocate connection between subpools // if ro/rw was updated. if e.conn == nil { - p.tryConnect(ctx, e) + if err := p.tryConnect(ctx, e); err != nil { + log.Printf("tarantool: reopen connection to %s failed: %s\n", + e.name, err) + } } else if !e.conn.ClosedNow() { p.updateConnection(e) } else {