From 1d44145699318a0b09339404b7d7d50d92d0ada1 Mon Sep 17 00:00:00 2001 From: Denis Lisov Date: Fri, 26 Jul 2013 14:39:26 +0400 Subject: [PATCH] remember lastFaviconRefresh if favicon unchanged Ported from Brief --- modules/FeedUpdateService.jsm | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/modules/FeedUpdateService.jsm b/modules/FeedUpdateService.jsm index c3d5c35..6a541a3 100644 --- a/modules/FeedUpdateService.jsm +++ b/modules/FeedUpdateService.jsm @@ -534,13 +534,14 @@ FaviconFetcher.prototype = { finish: function FaviconFetcher_finish(aFaviconString) { this.feed.lastFaviconRefresh = Date.now(); + let oldFaviconString = this.feed.favicon; + this.feed.favicon = aFaviconString; - if (this.feed.favicon != aFaviconString) { - this.feed.favicon = aFaviconString; - Storage.updateFeedProperties(this.feed); + yield Storage.updateFeedProperties(this.feed, FaviconFetcher_finish.resume); + + if (oldFaviconString != aFaviconString) Services.obs.notifyObservers(null, 'brief:feed-favicon-changed', this.feed.feedID); - } - }, + }.gen(), // nsIRequestObserver onStartRequest: function FaviconFetcher_lonStartRequest(aRequest, aContext) {