Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize config file reading #52

Open
taneliang opened this issue Aug 15, 2020 · 0 comments
Open

Centralize config file reading #52

taneliang opened this issue Aug 15, 2020 · 0 comments
Assignees
@taneliang
Labels
importance: 1 - must have Must be implemented for the product to be complete urgency: 2 - we can wait work type: implementation A task that primarily involves bashing code
Milestone
Launch

Comments

@taneliang
Copy link
Owner

The config file is currently being read in multiple places. Apart from being unclean, it may also introduce bugs as we don't validate inputs, causing weird crashes in random places that end users will not be able to understand.

We can also investigate using https://github.com/davidtheclark/cosmiconfig.
@taneliang taneliang added work type: implementation A task that primarily involves bashing code urgency: 2 - we can wait importance: 1 - must have Must be implemented for the product to be complete labels Aug 15, 2020
@taneliang taneliang added this to the Launch milestone Aug 15, 2020
@taneliang taneliang self-assigned this Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taneliang taneliang

Labels
importance: 1 - must have Must be implemented for the product to be complete urgency: 2 - we can wait work type: implementation A task that primarily involves bashing code
Projects
None yet
Milestone
Launch
Development

No branches or pull requests
1 participant
@taneliang