From e8512df30b3c4c6d0a43bd3542086dec0f7c37ee Mon Sep 17 00:00:00 2001 From: Andrew Kirwin Date: Wed, 1 Mar 2023 18:27:15 +0000 Subject: [PATCH] update api --- addon/components/expander/index.js | 32 ++++++++----------- tests/integration/components/expander-test.js | 2 +- 2 files changed, 15 insertions(+), 19 deletions(-) diff --git a/addon/components/expander/index.js b/addon/components/expander/index.js index 4b5eb10..7153656 100644 --- a/addon/components/expander/index.js +++ b/addon/components/expander/index.js @@ -147,27 +147,23 @@ class ExpanderComponent extends Component { }); } + get _api() { + return { + Button: this.Button, + Content: this.renderContent ? this.Content : null, + contentElement: this.contentElement, + toggle: this.toggle, + expand: this.expand, + collapse: this.collapse, + isExpanded: this.isExpanded, + isTransitioning: this.isTransitioning + }; + } + api = new Proxy(this, { get(target, key) { - if ( - ![ - 'Button', - 'Content', - 'contentElement', - 'toggle', - 'expand', - 'collapse', - 'isExpanded', - 'isTransitioning' - ].includes(key) || - (key === 'Content' && !target.renderContent) - ) { - return; - } - - return target[key]; + return target._api[key]; }, - set() {} }); } diff --git a/tests/integration/components/expander-test.js b/tests/integration/components/expander-test.js index dee50e7..7905da5 100644 --- a/tests/integration/components/expander-test.js +++ b/tests/integration/components/expander-test.js @@ -216,7 +216,7 @@ module('expander', function (hooks) { `); - assert.strictEqual(this.api.Content, undefined); + assert.strictEqual(this.api.Content, null); assert.strictEqual(typeof this.api.Button, 'object'); assert.deepEqual(this.api.contentElement, null); assert.strictEqual(typeof this.api.toggle, 'function');