Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with exercises and name conflict #2

Closed
mikeckennedy opened this issue Jul 10, 2024 · 2 comments
Closed

Error with exercises and name conflict #2

mikeckennedy opened this issue Jul 10, 2024 · 2 comments

Comments

@mikeckennedy
Copy link
Member

Hey @garrettgman Can you do some a bit more clean up for us here? I appreciate the changes you've synced over from Posit. However, the github pages version that the students run exercises on the web for this course don't work and the git history is such that they can't just sync across.

For example, see:

https://talkpython.github.io/reactive-web-dashboards-with-shiny-course/exercises/2-basic-ui.html

You get this error on the problems section of basic UI 2.4

Screenshot 2024-07-10 at 12 27 14 PM
@garrettgman
Copy link
Collaborator

@mikeckennedy I'm happy to help!

Can you help me understand the problem a little better? Did you by chance fix it? Your screenshot captures the error I attempted to fix with the PR. When I visit your link, things seem to be working. I see the fixed version below (The PR replaced metric() with metric_plot()).

Screenshot 2024-07-10 at 3 38 38 PM

@mikeckennedy
Copy link
Member Author

Thanks @garrettgman

You know what happened? I knew of that bug and thought your PR fixed it. So I merged, then went over to check. It was still a problem. Because github pages didn't publish instantly. Looks fixed, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants