Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ring dependency to 0.17.0 #243

Closed
grubles opened this issue Oct 3, 2023 · 11 comments · Fixed by #248
Closed

Bump ring dependency to 0.17.0 #243

grubles opened this issue Oct 3, 2023 · 11 comments · Fixed by #248

Comments

@grubles
Copy link

grubles commented Oct 3, 2023

0.16.20 does not support ppc64le arch. The recently released 0.17.0 does. Is there anything that would prevent bumping the version?

@sr-gi
Copy link
Member

sr-gi commented Oct 3, 2023

ring is not a direct dependency of teos, but on the dependency chain of rcgen IIRC.

Looks like the latest version of rcgen (0.11.3) still uses ring 0.16. I wouldn't mind bumping rcgen's version once it includes ring 0.17.0.

What is your use-case btw, deploying teos on a PowerPC?

@grubles
Copy link
Author

grubles commented Oct 3, 2023

Yes I have a beefy modern POWER machine I'd like to run a watchtower on for friends.

@grubles
Copy link
Author

grubles commented Dec 25, 2023

Looks like rcgen 0.12.0 is now released and includes ring 0.17. https://github.com/rustls/rcgen/blob/main/rcgen/CHANGELOG.md#release-0120---december-16-2023

@sr-gi
Copy link
Member

sr-gi commented Dec 29, 2023

@grubles would you mind giving #248 a go?

@grubles
Copy link
Author

grubles commented Dec 29, 2023

If I build using cargo install --path teos, I still hit an error about ring v0.16.20. Should I be building a different way? Sorry, not super familiar with building rust projects.

error: failed to run custom build command for `ring v0.16.20`

Caused by:
  process didn't exit successfully: `/home/user/builds/rust-teos/target/release/build/ring-893e2ab3b92e0036/build-script-build` (exit status: 101)
  --- stderr
  thread 'main' panicked at /home/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ring-0.16.20/build.rs:358:10:
  called `Option::unwrap()` on a `None` value
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error: failed to compile `teos v0.2.0 (/home/user/builds/rust-teos/teos)`, intermediate artifacts can be found at `/home/user/builds/rust-teos/target`.

@sr-gi
Copy link
Member

sr-gi commented Dec 30, 2023

Ok, my bad. Looks like rcgen was not our only dependency that had a dependency chain with ring 0.16. Turns out tonic does too (a double one actually: tonic -> rustls - > ring and tonic -> tokio-rustls - > rustls -> ring).

The good news is that rustls v22 already uses ring v17 (ref), and the last version of tokio-rustls uses rustls v22 (ref). The bad news is that tonic has not yet updated to any of them (ref), so we are still stuck until our dependencies bumps theirs.

@grubles
Copy link
Author

grubles commented Dec 30, 2023

Ah bummer I was afraid that was the case. Okay I suppose we wait until tonic is updated then.

@sr-gi
Copy link
Member

sr-gi commented Jul 26, 2024

@grubles, all dependencies with ring 0.16 should have been removed now in #248. Would you mind giving that a go? CI failures should be unrelated

@grubles
Copy link
Author

grubles commented Jul 26, 2024

Great! Using 248 I am able to build now.

Installed package `teos v0.2.0 (/home/user/builds/rust-teos/teos)` (executables `teos-cli`, `teosd`)

@sr-gi
Copy link
Member

sr-gi commented Jul 26, 2024

Can you try if the grpc client can properly connect to the server by issuing some teos-cli commands?

@sr-gi
Copy link
Member

sr-gi commented Jul 29, 2024

There was an issue with teos-cli, but it should be fixed now in the new version of #248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants