Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-dom is not listed in peerDependencies #228

Open
kirill-konshin opened this issue Feb 29, 2020 · 3 comments
Open

react-dom is not listed in peerDependencies #228

kirill-konshin opened this issue Feb 29, 2020 · 3 comments

Comments

@kirill-konshin
Copy link

react-dom is not listed in peerDependencies which causes Yarn 2 in plug'n'play mode to fail
@dasdachs
Copy link

@kirill-konshin Any solution for this?

@kirill-konshin
Copy link
Author

@dasdachs add this to .yarnrc.yml:

packageExtensions:
  react-portal@*:
    peerDependencies:
      react-dom: "*"

@tajo is this project alive? Yarn 2 has been released long ago, please fix properly.

@tajo tajo mentioned this issue Oct 20, 2020
Closed
@dasdachs
Copy link

@kirill-konshin Thanks, that did the trick. I did a PR regarding this, but it fails due to an conflicting peer dependency. Will try to solve this today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added react-dom to peerDependencies dasdachs/react-portal
2 participants
@kirill-konshin @dasdachs