Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create @call operator #1064

Merged

Conversation

ologbonowiwi
Copy link
Contributor

@ologbonowiwi ologbonowiwi commented Jan 29, 2024

Issue Reference(s):
Fixes #846
/claim #846

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@algora-pbc algora-pbc bot mentioned this pull request Jan 29, 2024
@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Jan 29, 2024
@ologbonowiwi ologbonowiwi force-pushed the feat/#846/create-call-operator branch from 0c56c4f to 7dc62fd Compare January 29, 2024 17:13
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: Patch coverage is 96.21849% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 88.84%. Comparing base (64f0f71) to head (045d9bd).

Files Patch % Lines
src/blueprint/operators/call.rs 95.94% 6 Missing ⚠️
src/blueprint/operators/const_field.rs 95.23% 1 Missing ⚠️
src/blueprint/operators/expr.rs 50.00% 1 Missing ⚠️
src/config/expr.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1064      +/-   ##
==========================================
+ Coverage   88.57%   88.84%   +0.27%     
==========================================
  Files         106      107       +1     
  Lines       11997    12193     +196     
==========================================
+ Hits        10626    10833     +207     
+ Misses       1371     1360      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ologbonowiwi ologbonowiwi force-pushed the feat/#846/create-call-operator branch from 88f3a1b to 5614a4d Compare January 29, 2024 17:24
@ologbonowiwi ologbonowiwi force-pushed the feat/#846/create-call-operator branch from 5614a4d to 35d5548 Compare January 29, 2024 17:26
@ologbonowiwi ologbonowiwi force-pushed the feat/#846/create-call-operator branch from ffa6b28 to fe0f59d Compare January 29, 2024 17:39
Copy link

github-actions bot commented Feb 6, 2024

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Feb 6, 2024
Copy link

github-actions bot commented Feb 8, 2024

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Feb 8, 2024
@tusharmath
Copy link
Contributor

@ologbonowiwi I want to come back to this. Can you resolve conflicts once.

@ologbonowiwi ologbonowiwi force-pushed the feat/#846/create-call-operator branch from 110ef3a to 8560cfd Compare February 29, 2024 04:11
@tusharmath tusharmath enabled auto-merge (squash) March 4, 2024 11:41
@tusharmath
Copy link
Contributor

Thanks @ologbonowiwi!

Looking forward to it's documentation on the website :)
/tip 100$

Copy link

algora-pbc bot commented Mar 4, 2024

@ologbonowiwi: You just got a $100 tip! We'll notify you once it is processed.

@tusharmath tusharmath merged commit 607d336 into tailcallhq:main Mar 4, 2024
14 checks passed
Copy link

algora-pbc bot commented Mar 4, 2024

🎉🎈 @ologbonowiwi has been awarded $100! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim 💰 Rewarded type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a @call operator
2 participants