Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update upstream #2833

Closed
wants to merge 9 commits into from
Closed

refactor: update upstream #2833

wants to merge 9 commits into from
+610 −428

Conversation

ssddOnTop
Copy link
Member

Issue Reference(s):
Fixes #2823

@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Sep 16, 2024
@ssddOnTop ssddOnTop marked this pull request as draft September 16, 2024 20:41
@github-actions github-actions bot added the ci: benchmark Runs benchmarks label Sep 19, 2024
@github-actions GitHub Actions
Copy link

🐰 Bencher Report

Branch2833/merge
Testbedbenchmarking-runner
🚨 2 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure
Units		ViewBenchmark Result
(Result Δ%)		Lower Boundary
(Limit %)		Upper Boundary
(Limit %)
input/headers.existingLatency
nanoseconds (ns)		📈 plot
🚨 alert
🚷 threshold		36.49
(+15.50%)		34.18
(106.76%)
input/headers.missingLatency
nanoseconds (ns)		📈 plot
🚨 alert
🚷 threshold		35.38
(+15.34%)		33.53
(105.49%)
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
from_json_bench📈 view plot
🚷 view threshold		6,254,200.00
(+1.25%)		6,304,888.48
(99.20%)
group_by📈 view plot
🚷 view threshold		489.26
(-0.14%)		513.65
(95.25%)
input/args.missing📈 view plot
🚷 view threshold		25.23
(-1.56%)		27.74
(90.96%)
input/args.nested.existing📈 view plot
🚷 view threshold		44.98
(-1.09%)		48.31
(93.11%)
input/args.nested.missing📈 view plot
🚷 view threshold		38.23
(-1.15%)		40.84
(93.61%)
input/args.root📈 view plot
🚷 view threshold		40.93
(-1.03%)		45.03
(90.90%)
input/headers.existing📈 view plot
🚨 view alert
🚷 view threshold		36.49
(+15.50%)		34.18
(106.76%)
input/headers.missing📈 view plot
🚨 view alert
🚷 view threshold		35.38
(+15.34%)		33.53
(105.49%)
input/value.missing📈 view plot
🚷 view threshold		23.40
(+0.06%)		24.67
(94.82%)
input/value.nested.existing📈 view plot
🚷 view threshold		42.42
(-1.58%)		45.77
(92.69%)
input/value.nested.missing📈 view plot
🚷 view threshold		36.62
(-0.04%)		38.57
(94.97%)
input/value.root📈 view plot
🚷 view threshold		38.41
(-0.77%)		41.63
(92.28%)
input/vars.existing📈 view plot
🚷 view threshold		8.11
(-2.16%)		9.41
(86.25%)
input/vars.missing📈 view plot
🚷 view threshold		7.86
(-12.03%)		11.51
(68.32%)
synth_nested📈 view plot
🚷 view threshold		138,360.00
(+23.32%)		175,338.87
(78.91%)
synth_nested_borrow📈 view plot
🚷 view threshold		83,205.00
(+63.10%)		102,260.09
(81.37%)
test_batched_body📈 view plot
🚷 view threshold		1,901.50
(-2.13%)		2,080.71
(91.39%)
test_batched_body #2📈 view plot
🚷 view threshold		1,580,900.00
(-0.19%)		1,731,833.65
(91.28%)
test_data_loader📈 view plot
🚷 view threshold		402,700.00
(-1.27%)		458,671.69
(87.80%)
test_handle_request📈 view plot
🚷 view threshold		135,680.00
(-2.72%)		150,080.22
(90.40%)
test_handle_request_jit📈 view plot
🚷 view threshold		97,967.00
(-11.78%)		149,627.71
(65.47%)
test_http_execute_method📈 view plot
🚷 view threshold		14,626.00
(+1.82%)		14,886.51
(98.25%)
with_mustache_expressions📈 view plot
🚷 view threshold		1,141.70
(+2.84%)		1,177.71
(96.94%)
with_mustache_literal📈 view plot
🚷 view threshold		728.93
(+2.39%)		763.90
(95.42%)
🐰 View full continuous benchmarking report in Bencher

@tusharmath tusharmath removed the ci: benchmark Runs benchmarks label Sep 21, 2024
@github-actions github-actions bot added the ci: benchmark Runs benchmarks label Sep 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 1, 2024
@ssddOnTop ssddOnTop removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 7, 2024
@ssddOnTop ssddOnTop removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 8, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 13, 2024
@ssddOnTop ssddOnTop removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 21, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 26, 2024
@github-actions GitHub Actions
Copy link

PR closed after 10 days of inactivity.

@github-actions github-actions bot closed this Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci: benchmark Runs benchmarks state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: update upstream
2 participants
@ssddOnTop @tusharmath