Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move server.responseHeaders to server.headers.custom #1400

Closed
tusharmath opened this issue Mar 12, 2024 · 10 comments · Fixed by #1402
Closed

move server.responseHeaders to server.headers.custom #1400

tusharmath opened this issue Mar 12, 2024 · 10 comments · Fixed by #1402

Comments

@tusharmath
Copy link
Contributor

tusharmath commented Mar 12, 2024

Currently response headers add additional headers to the final response. Move this setting from @server to @server.headers.custom.

Current

schema @server(responseHeaders: [{key: "X-Allowed-Roles", value: "admin,user"}]) {
  query: Query
  mutation: Mutation
}

Proposed

schema @server(headers: {custom: [{key: "X-Allowed-Roles", value: "admin,user"}]}) {
  query: Query
  mutation: Mutation
}

NOTE: Update the documentation here https://tailcall.run/docs/operators/server/#responseheaders

@tusharmath
Copy link
Contributor Author

/bounty 50

Copy link

algora-pbc bot commented Mar 12, 2024

💎 $50 bounty created by tailcallhq
🙋 If you'd like to work on this issue, comment below to get assigned
👉 To claim this bounty, submit a pull request that includes the text /claim #1400 somewhere in its body

📝 Before proceeding, please make sure you can receive payouts in your country.
💵 Payment arrives in your account 2-5 days after the bounty is rewarded.
💯 You keep 100% of the bounty award.
👍 If you go above and beyond by cleaning up or enhancing aspects beyond the scope of the PR, a tip may be awarded as a token of appreciation.
🙏 Thank you for contributing to tailcallhq/tailcall!.
🙋‍♂️ Join our discord channel if you need help.

👉 Add a bountyShare on socials

Copy link

algora-pbc bot commented Mar 12, 2024

@neo773: The Tailcall Inc. team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started.

@tusharmath
Copy link
Contributor Author

@neo773 Are you still on this?

@neo773
Copy link
Contributor

neo773 commented Mar 12, 2024

@tusharmath
no

@ologbonowiwi
Copy link
Contributor

ologbonowiwi commented Mar 12, 2024

/attempt #1400

Algora profile Completed bounties Tech Active attempts Options
@ologbonowiwi    24 tailcallhq bounties
+ 19 bounties from 5 projects
Rust, TypeScript,
Shell & more
Cancel attempt

Copy link

algora-pbc bot commented Mar 12, 2024

@ologbonowiwi: The Tailcall Inc. team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started.

Copy link

algora-pbc bot commented Mar 12, 2024

💡 @ologbonowiwi submitted a pull request that claims the bounty. You can visit your bounty board to reward.

tusharmath added a commit to ologbonowiwi/tailcall that referenced this issue Mar 13, 2024
tusharmath added a commit to ologbonowiwi/tailcall that referenced this issue Mar 13, 2024
ologbonowiwi added a commit to ologbonowiwi/tailcall that referenced this issue Mar 13, 2024
…-server-headers-custom' of github.com:ologbonowiwi/tailcall into refactor/tailcallhq#1400/move-server-responseHeaders-to-server-headers-custom
ologbonowiwi added a commit to ologbonowiwi/tailcall that referenced this issue Mar 13, 2024
Copy link

algora-pbc bot commented Mar 13, 2024

@ologbonowiwi: Your claim has been rewarded! We'll notify you once it is processed.

Copy link

algora-pbc bot commented Mar 14, 2024

🎉🎈 @ologbonowiwi has been awarded $50! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants