Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

In-circuit blockhash calculation #98

Closed
wants to merge 49 commits into from

fmt + clippy

54d6f05
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Closed

In-circuit blockhash calculation #98

fmt + clippy
54d6f05
Select commit
Loading
Failed to load commit list.
GitHub Actions / Clippy failed Jun 30, 2023 in 0s

Clippy

34 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 34
Warning 0
Note 0
Help 0

Versions

  • rustc 1.65.0-nightly (015a824f2 2022-08-22)
  • cargo 1.65.0-nightly (9809f8ff3 2022-08-16)
  • clippy 0.1.65 (015a824 2022-08-22)

Annotations

Check failure on line 373 in circuit-benchmarks/examples/pi_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

use of `expect` followed by a function call

error: use of `expect` followed by a function call
   --> circuit-benchmarks/examples/pi_circuit_integration.rs:373:29
    |
373 |     fs::create_dir_all(dir).expect(format!("create {:?}", dir).as_str());
    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("create {:?}", dir))`
    |
    = note: `-D clippy::expect-fun-call` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call

Check failure on line 295 in circuit-benchmarks/examples/pi_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

this expression creates a reference which is immediately dereferenced by the compiler

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> circuit-benchmarks/examples/pi_circuit_integration.rs:295:20
    |
295 |         .write_all(&loader.yul_code().as_bytes())
    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `loader.yul_code().as_bytes()`
    |
    = note: `-D clippy::needless-borrow` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check failure on line 292 in circuit-benchmarks/examples/pi_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

use of `unwrap_or` followed by a function call

error: use of `unwrap_or` followed by a function call
   --> circuit-benchmarks/examples/pi_circuit_integration.rs:292:36
    |
292 |     let file_path = &yul_file_name.unwrap_or(String::from("./PlonkEvmVerifier.sol"));
    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("./PlonkEvmVerifier.sol"))`
    |
    = note: `-D clippy::or-fun-call` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call

Check failure on line 315 in circuit-benchmarks/examples/super_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

use of `expect` followed by a function call

error: use of `expect` followed by a function call
   --> circuit-benchmarks/examples/super_circuit_integration.rs:315:29
    |
315 |     fs::create_dir_all(dir).expect(format!("create {:?}", dir).as_str());
    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("create {:?}", dir))`
    |
    = note: `-D clippy::expect-fun-call` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call

Check failure on line 237 in circuit-benchmarks/examples/super_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

this expression creates a reference which is immediately dereferenced by the compiler

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> circuit-benchmarks/examples/super_circuit_integration.rs:237:20
    |
237 |         .write_all(&loader.yul_code().as_bytes())
    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `loader.yul_code().as_bytes()`
    |
    = note: `-D clippy::needless-borrow` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check failure on line 265 in circuit-benchmarks/examples/super_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

function `gen_proof` is never used

error: function `gen_proof` is never used
   --> circuit-benchmarks/examples/super_circuit_integration.rs:265:4
    |
265 | fn gen_proof<C: Circuit<Fr>>(
    |    ^^^^^^^^^

Check failure on line 243 in circuit-benchmarks/examples/super_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

function `evm_verify` is never used

error: function `evm_verify` is never used
   --> circuit-benchmarks/examples/super_circuit_integration.rs:243:4
    |
243 | fn evm_verify(deployment_code: Vec<u8>, instances: Vec<Vec<Fr>>, proof: Vec<u8>) {
    |    ^^^^^^^^^^
    |
    = note: `-D dead-code` implied by `-D warnings`

Check failure on line 416 in circuit-benchmarks/examples/super_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused variable: `deployment_code`

error: unused variable: `deployment_code`
   --> circuit-benchmarks/examples/super_circuit_integration.rs:416:9
    |
416 |     let deployment_code = gen_evm_verifier(
    |         ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_deployment_code`

Check failure on line 396 in circuit-benchmarks/examples/super_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused variable: `instance`

error: unused variable: `instance`
   --> circuit-benchmarks/examples/super_circuit_integration.rs:396:26
    |
396 |     let (min_k, circuit, instance) =
    |                          ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_instance`

Check failure on line 389 in circuit-benchmarks/examples/super_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused variable: `eth_block`

error: unused variable: `eth_block`
   --> circuit-benchmarks/examples/super_circuit_integration.rs:389:19
    |
389 |     let (builder, eth_block) = builder.gen_inputs(config.block_num).await?;
    |                   ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_eth_block`
    |
    = note: `-D unused-variables` implied by `-D warnings`

Check failure on line 6 in circuit-benchmarks/examples/super_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused import: `ethers_signers::Signer`

error: unused import: `ethers_signers::Signer`
 --> circuit-benchmarks/examples/super_circuit_integration.rs:6:5
  |
6 | use ethers_signers::Signer;
  |     ^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 29 in circuit-benchmarks/examples/super_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused import: `zkevm_circuits::util::SubCircuit`

error: unused import: `zkevm_circuits::util::SubCircuit`
  --> circuit-benchmarks/examples/super_circuit_integration.rs:29:5
   |
29 | use zkevm_circuits::util::SubCircuit;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 25 in circuit-benchmarks/examples/super_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused import: `std::io::Read`

error: unused import: `std::io::Read`
  --> circuit-benchmarks/examples/super_circuit_integration.rs:25:5
   |
25 | use std::io::Read;
   |     ^^^^^^^^^^^^^

Check failure on line 359 in circuit-benchmarks/examples/super_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused import: `zkevm_circuits::tx_circuit::PrimeField`

error: unused import: `zkevm_circuits::tx_circuit::PrimeField`
   --> circuit-benchmarks/examples/super_circuit_integration.rs:359:5
    |
359 | use zkevm_circuits::tx_circuit::PrimeField;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 355 in circuit-benchmarks/examples/super_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused imports: `Deserialize`, `Serialize`

error: unused imports: `Deserialize`, `Serialize`
   --> circuit-benchmarks/examples/super_circuit_integration.rs:355:13
    |
355 | use serde::{Deserialize, Serialize};
    |             ^^^^^^^^^^^  ^^^^^^^^^

Check failure on line 163 in circuit-benchmarks/examples/super_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused imports: `io::Cursor`, `time::Instant`

error: unused imports: `io::Cursor`, `time::Instant`
   --> circuit-benchmarks/examples/super_circuit_integration.rs:163:11
    |
163 | use std::{io::Cursor, io::Write, rc::Rc, time::Instant};
    |           ^^^^^^^^^^                     ^^^^^^^^^^^^^

Check failure on line 28 in circuit-benchmarks/examples/super_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused import: `zkevm_circuits::test_util::rand_tx`

error: unused import: `zkevm_circuits::test_util::rand_tx`
  --> circuit-benchmarks/examples/super_circuit_integration.rs:28:5
   |
28 | use zkevm_circuits::test_util::rand_tx;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 26 in circuit-benchmarks/examples/super_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused imports: `PiCircuit`, `PiTestCircuit`, `PublicData`

error: unused imports: `PiCircuit`, `PiTestCircuit`, `PublicData`
  --> circuit-benchmarks/examples/super_circuit_integration.rs:26:34
   |
26 | use zkevm_circuits::pi_circuit::{PiCircuit, PiTestCircuit, PublicData};
   |                                  ^^^^^^^^^  ^^^^^^^^^^^^^  ^^^^^^^^^^

Check failure on line 24 in circuit-benchmarks/examples/super_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused import: `std::env::var`

error: unused import: `std::env::var`
  --> circuit-benchmarks/examples/super_circuit_integration.rs:24:5
   |
24 | use std::env::var;
   |     ^^^^^^^^^^^^^

Check failure on line 23 in circuit-benchmarks/examples/super_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused import: `std::collections::HashMap`

error: unused import: `std::collections::HashMap`
  --> circuit-benchmarks/examples/super_circuit_integration.rs:23:5
   |
23 | use std::collections::HashMap;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 22 in circuit-benchmarks/examples/super_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused import: `rand_xorshift::XorShiftRng`

error: unused import: `rand_xorshift::XorShiftRng`
  --> circuit-benchmarks/examples/super_circuit_integration.rs:22:5
   |
22 | use rand_xorshift::XorShiftRng;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 21 in circuit-benchmarks/examples/super_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused imports: `ChaCha20Rng`, `ChaChaRng`

error: unused imports: `ChaCha20Rng`, `ChaChaRng`
  --> circuit-benchmarks/examples/super_circuit_integration.rs:21:19
   |
21 | use rand_chacha::{ChaCha20Rng, ChaChaRng};
   |                   ^^^^^^^^^^^  ^^^^^^^^^

Check failure on line 20 in circuit-benchmarks/examples/super_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused import: `rand::SeedableRng`

error: unused import: `rand::SeedableRng`
  --> circuit-benchmarks/examples/super_circuit_integration.rs:20:5
   |
20 | use rand::SeedableRng;
   |     ^^^^^^^^^^^^^^^^^

Check failure on line 19 in circuit-benchmarks/examples/super_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused imports: `MOCK_CHAIN_ID`, `TestContext`

error: unused imports: `MOCK_CHAIN_ID`, `TestContext`
  --> circuit-benchmarks/examples/super_circuit_integration.rs:19:12
   |
19 | use mock::{TestContext, MOCK_CHAIN_ID};
   |            ^^^^^^^^^^^  ^^^^^^^^^^^^^

Check failure on line 16 in circuit-benchmarks/examples/super_circuit_integration.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy

unused imports: `Blake2bRead`, `Blake2bWrite`, `Challenge255`

error: unused imports: `Blake2bRead`, `Blake2bWrite`, `Challenge255`
  --> circuit-benchmarks/examples/super_circuit_integration.rs:16:9
   |
16 |         Blake2bRead, Blake2bWrite, Challenge255, TranscriptReadBuffer, TranscriptWriterBuffer,
   |         ^^^^^^^^^^^  ^^^^^^^^^^^^  ^^^^^^^^^^^^