Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Support eip-1559 and Evm-circuit in aggregation #136

Merged
merged 61 commits into from
Sep 21, 2023

Conversation

johntaiko
Copy link

@johntaiko johntaiko commented Aug 11, 2023

Previous: smtmfft#18

Tasks:

@johntaiko
Copy link
Author

@Brechtpd Now, we use taiko flag to enable the anchor logics.
Also, we only use the type-2-transaction for our zkevm. And update signature to eip-2718

@johntaiko johntaiko force-pushed the feat/evm_circuit_1559 branch 2 times, most recently from e3451a5 to 2196cf8 Compare August 20, 2023 13:45
…es (privacy-scaling-explorations#1424)

1. Add Shanghai related fields to chain config in geth-utils.

2. EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to
Begin TX.

3. Part of EIP-3860 (Limit and meter initcode): only add gas cost of
init code to Begin TX (missing gas cost changes in Create and OOG
Create).

Issue
privacy-scaling-explorations#1362

Local related PRs:
scroll-tech#497
scroll-tech#500
scroll-tech#507

Reference previous PR:
privacy-scaling-explorations#1361

- [x] Breaking change (fix or feature that would cause existing
functionality to not work as expected)

Unit test cases of CI could pass with Shanghai geth traces.

---------

Co-authored-by: Zhang Zhuo <[email protected]>
@johntaiko
Copy link
Author

johntaiko commented Aug 21, 2023

Using real data with one anchor transaction is passed in zkevm-chain. taikoxyz/zkevm-chain#6
@Brechtpd @smtmfft Please take look again

@Brechtpd
Copy link

Looked through the code again, all looks good to me!

@johntaiko johntaiko self-assigned this Aug 23, 2023
@johntaiko johntaiko changed the base branch from main to feat/for-a6-release September 21, 2023 06:05
@johntaiko johntaiko marked this pull request as ready for review September 21, 2023 06:06
@smtmfft smtmfft merged commit 1025748 into taikoxyz:feat/for-a6-release Sep 21, 2023
16 of 19 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Integrate EVM circuit into TaikoSuperCircuit EIP1559 support
5 participants