This repository has been archived by the owner on May 3, 2024. It is now read-only.
In-circuit blockhash calculation #419
ggkitsasAnnotations
34 errors
|
use of `expect` followed by a function call:
circuit-benchmarks/examples/pi_circuit_integration.rs#L373
error: use of `expect` followed by a function call
--> circuit-benchmarks/examples/pi_circuit_integration.rs:373:29
|
373 | fs::create_dir_all(dir).expect(format!("create {:?}", dir).as_str());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("create {:?}", dir))`
|
= note: `-D clippy::expect-fun-call` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
circuit-benchmarks/examples/pi_circuit_integration.rs#L295
error: this expression creates a reference which is immediately dereferenced by the compiler
--> circuit-benchmarks/examples/pi_circuit_integration.rs:295:20
|
295 | .write_all(&loader.yul_code().as_bytes())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `loader.yul_code().as_bytes()`
|
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
use of `unwrap_or` followed by a function call:
circuit-benchmarks/examples/pi_circuit_integration.rs#L292
error: use of `unwrap_or` followed by a function call
--> circuit-benchmarks/examples/pi_circuit_integration.rs:292:36
|
292 | let file_path = &yul_file_name.unwrap_or(String::from("./PlonkEvmVerifier.sol"));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("./PlonkEvmVerifier.sol"))`
|
= note: `-D clippy::or-fun-call` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
|
|
use of `expect` followed by a function call:
circuit-benchmarks/examples/super_circuit_integration.rs#L315
error: use of `expect` followed by a function call
--> circuit-benchmarks/examples/super_circuit_integration.rs:315:29
|
315 | fs::create_dir_all(dir).expect(format!("create {:?}", dir).as_str());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("create {:?}", dir))`
|
= note: `-D clippy::expect-fun-call` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
circuit-benchmarks/examples/super_circuit_integration.rs#L237
error: this expression creates a reference which is immediately dereferenced by the compiler
--> circuit-benchmarks/examples/super_circuit_integration.rs:237:20
|
237 | .write_all(&loader.yul_code().as_bytes())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `loader.yul_code().as_bytes()`
|
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
function `gen_proof` is never used:
circuit-benchmarks/examples/super_circuit_integration.rs#L265
error: function `gen_proof` is never used
--> circuit-benchmarks/examples/super_circuit_integration.rs:265:4
|
265 | fn gen_proof<C: Circuit<Fr>>(
| ^^^^^^^^^
|
|
function `evm_verify` is never used:
circuit-benchmarks/examples/super_circuit_integration.rs#L243
error: function `evm_verify` is never used
--> circuit-benchmarks/examples/super_circuit_integration.rs:243:4
|
243 | fn evm_verify(deployment_code: Vec<u8>, instances: Vec<Vec<Fr>>, proof: Vec<u8>) {
| ^^^^^^^^^^
|
= note: `-D dead-code` implied by `-D warnings`
|
|
unused variable: `deployment_code`:
circuit-benchmarks/examples/super_circuit_integration.rs#L416
error: unused variable: `deployment_code`
--> circuit-benchmarks/examples/super_circuit_integration.rs:416:9
|
416 | let deployment_code = gen_evm_verifier(
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_deployment_code`
|
|
unused variable: `instance`:
circuit-benchmarks/examples/super_circuit_integration.rs#L396
error: unused variable: `instance`
--> circuit-benchmarks/examples/super_circuit_integration.rs:396:26
|
396 | let (min_k, circuit, instance) =
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_instance`
|
|
unused variable: `eth_block`:
circuit-benchmarks/examples/super_circuit_integration.rs#L389
error: unused variable: `eth_block`
--> circuit-benchmarks/examples/super_circuit_integration.rs:389:19
|
389 | let (builder, eth_block) = builder.gen_inputs(config.block_num).await?;
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_eth_block`
|
= note: `-D unused-variables` implied by `-D warnings`
|
|
unused import: `ethers_signers::Signer`:
circuit-benchmarks/examples/super_circuit_integration.rs#L6
error: unused import: `ethers_signers::Signer`
--> circuit-benchmarks/examples/super_circuit_integration.rs:6:5
|
6 | use ethers_signers::Signer;
| ^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `zkevm_circuits::util::SubCircuit`:
circuit-benchmarks/examples/super_circuit_integration.rs#L29
error: unused import: `zkevm_circuits::util::SubCircuit`
--> circuit-benchmarks/examples/super_circuit_integration.rs:29:5
|
29 | use zkevm_circuits::util::SubCircuit;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `std::io::Read`:
circuit-benchmarks/examples/super_circuit_integration.rs#L25
error: unused import: `std::io::Read`
--> circuit-benchmarks/examples/super_circuit_integration.rs:25:5
|
25 | use std::io::Read;
| ^^^^^^^^^^^^^
|
|
unused import: `zkevm_circuits::tx_circuit::PrimeField`:
circuit-benchmarks/examples/super_circuit_integration.rs#L359
error: unused import: `zkevm_circuits::tx_circuit::PrimeField`
--> circuit-benchmarks/examples/super_circuit_integration.rs:359:5
|
359 | use zkevm_circuits::tx_circuit::PrimeField;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused imports: `Deserialize`, `Serialize`:
circuit-benchmarks/examples/super_circuit_integration.rs#L355
error: unused imports: `Deserialize`, `Serialize`
--> circuit-benchmarks/examples/super_circuit_integration.rs:355:13
|
355 | use serde::{Deserialize, Serialize};
| ^^^^^^^^^^^ ^^^^^^^^^
|
|
unused imports: `io::Cursor`, `time::Instant`:
circuit-benchmarks/examples/super_circuit_integration.rs#L163
error: unused imports: `io::Cursor`, `time::Instant`
--> circuit-benchmarks/examples/super_circuit_integration.rs:163:11
|
163 | use std::{io::Cursor, io::Write, rc::Rc, time::Instant};
| ^^^^^^^^^^ ^^^^^^^^^^^^^
|
|
unused import: `zkevm_circuits::test_util::rand_tx`:
circuit-benchmarks/examples/super_circuit_integration.rs#L28
error: unused import: `zkevm_circuits::test_util::rand_tx`
--> circuit-benchmarks/examples/super_circuit_integration.rs:28:5
|
28 | use zkevm_circuits::test_util::rand_tx;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused imports: `PiCircuit`, `PiTestCircuit`, `PublicData`:
circuit-benchmarks/examples/super_circuit_integration.rs#L26
error: unused imports: `PiCircuit`, `PiTestCircuit`, `PublicData`
--> circuit-benchmarks/examples/super_circuit_integration.rs:26:34
|
26 | use zkevm_circuits::pi_circuit::{PiCircuit, PiTestCircuit, PublicData};
| ^^^^^^^^^ ^^^^^^^^^^^^^ ^^^^^^^^^^
|
|
unused import: `std::env::var`:
circuit-benchmarks/examples/super_circuit_integration.rs#L24
error: unused import: `std::env::var`
--> circuit-benchmarks/examples/super_circuit_integration.rs:24:5
|
24 | use std::env::var;
| ^^^^^^^^^^^^^
|
|
unused import: `std::collections::HashMap`:
circuit-benchmarks/examples/super_circuit_integration.rs#L23
error: unused import: `std::collections::HashMap`
--> circuit-benchmarks/examples/super_circuit_integration.rs:23:5
|
23 | use std::collections::HashMap;
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `rand_xorshift::XorShiftRng`:
circuit-benchmarks/examples/super_circuit_integration.rs#L22
error: unused import: `rand_xorshift::XorShiftRng`
--> circuit-benchmarks/examples/super_circuit_integration.rs:22:5
|
22 | use rand_xorshift::XorShiftRng;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused imports: `ChaCha20Rng`, `ChaChaRng`:
circuit-benchmarks/examples/super_circuit_integration.rs#L21
error: unused imports: `ChaCha20Rng`, `ChaChaRng`
--> circuit-benchmarks/examples/super_circuit_integration.rs:21:19
|
21 | use rand_chacha::{ChaCha20Rng, ChaChaRng};
| ^^^^^^^^^^^ ^^^^^^^^^
|
|
unused import: `rand::SeedableRng`:
circuit-benchmarks/examples/super_circuit_integration.rs#L20
error: unused import: `rand::SeedableRng`
--> circuit-benchmarks/examples/super_circuit_integration.rs:20:5
|
20 | use rand::SeedableRng;
| ^^^^^^^^^^^^^^^^^
|
|
unused imports: `MOCK_CHAIN_ID`, `TestContext`:
circuit-benchmarks/examples/super_circuit_integration.rs#L19
error: unused imports: `MOCK_CHAIN_ID`, `TestContext`
--> circuit-benchmarks/examples/super_circuit_integration.rs:19:12
|
19 | use mock::{TestContext, MOCK_CHAIN_ID};
| ^^^^^^^^^^^ ^^^^^^^^^^^^^
|
|
unused imports: `Blake2bRead`, `Blake2bWrite`, `Challenge255`:
circuit-benchmarks/examples/super_circuit_integration.rs#L16
error: unused imports: `Blake2bRead`, `Blake2bWrite`, `Challenge255`
--> circuit-benchmarks/examples/super_circuit_integration.rs:16:9
|
16 | Blake2bRead, Blake2bWrite, Challenge255, TranscriptReadBuffer, TranscriptWriterBuffer,
| ^^^^^^^^^^^ ^^^^^^^^^^^^ ^^^^^^^^^^^^
|
|
unused import: `halo2_proofs::poly::kzg::strategy::SingleStrategy`:
circuit-benchmarks/examples/super_circuit_integration.rs#L11
error: unused import: `halo2_proofs::poly::kzg::strategy::SingleStrategy`
--> circuit-benchmarks/examples/super_circuit_integration.rs:11:5
|
11 | use halo2_proofs::poly::kzg::strategy::SingleStrategy;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused imports: `ProverSHPLONK`, `VerifierSHPLONK`:
circuit-benchmarks/examples/super_circuit_integration.rs#L10
error: unused imports: `ProverSHPLONK`, `VerifierSHPLONK`
--> circuit-benchmarks/examples/super_circuit_integration.rs:10:42
|
10 | use halo2_proofs::poly::kzg::multiopen::{ProverSHPLONK, VerifierSHPLONK};
| ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^
|
|
unused import: `ParamsVerifierKZG`:
circuit-benchmarks/examples/super_circuit_integration.rs#L9
error: unused import: `ParamsVerifierKZG`
--> circuit-benchmarks/examples/super_circuit_integration.rs:9:75
|
9 | use halo2_proofs::poly::kzg::commitment::{KZGCommitmentScheme, ParamsKZG, ParamsVerifierKZG};
| ^^^^^^^^^^^^^^^^^
|
|
unused import: `halo2_proofs::arithmetic::Field`:
circuit-benchmarks/examples/super_circuit_integration.rs#L7
error: unused import: `halo2_proofs::arithmetic::Field`
--> circuit-benchmarks/examples/super_circuit_integration.rs:7:5
|
7 | use halo2_proofs::arithmetic::Field;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `ethers_signers::LocalWallet`:
circuit-benchmarks/examples/super_circuit_integration.rs#L5
error: unused import: `ethers_signers::LocalWallet`
--> circuit-benchmarks/examples/super_circuit_integration.rs:5:5
|
5 | use ethers_signers::LocalWallet;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused imports: `U256`, `Word`, `address`, `bytecode`:
circuit-benchmarks/examples/super_circuit_integration.rs#L4
error: unused imports: `U256`, `Word`, `address`, `bytecode`
--> circuit-benchmarks/examples/super_circuit_integration.rs:4:17
|
4 | use eth_types::{address, bytecode, Word, U256};
| ^^^^^^^ ^^^^^^^^ ^^^^ ^^^^
|
|
unused import: `eth_types::geth_types::GethData`:
circuit-benchmarks/examples/super_circuit_integration.rs#L3
error: unused import: `eth_types::geth_types::GethData`
--> circuit-benchmarks/examples/super_circuit_integration.rs:3:5
|
3 | use eth_types::geth_types::GethData;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused imports: `end_timer`, `start_timer`:
circuit-benchmarks/examples/super_circuit_integration.rs#L2
error: unused imports: `end_timer`, `start_timer`
--> circuit-benchmarks/examples/super_circuit_integration.rs:2:15
|
2 | use ark_std::{end_timer, start_timer};
| ^^^^^^^^^ ^^^^^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`
|
|
this import is redundant:
circuit-benchmarks/examples/pi_circuit_integration.rs#L11
error: this import is redundant
--> circuit-benchmarks/examples/pi_circuit_integration.rs:11:1
|
11 | use log;
| ^^^^^^^^ help: remove it entirely
|
= note: `-D clippy::single-component-path-imports` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
|