Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All pings recorded as "missed ping from 0s ago" #66

Open
mykter opened this issue Nov 9, 2016 · 6 comments
Open

All pings recorded as "missed ping from 0s ago" #66

mykter opened this issue Nov 9, 2016 · 6 comments

Comments

@mykter
Copy link

mykter commented Nov 9, 2016

Aside from my RETRO pings, all my pings start up in the editor with either:

err [missed ping from 0s ago]

or

err [missed ping from 1s ago]

without exception.

Running on cygwin, win7.

I guess there should be some tolerance in the check on line 61 of launch.pl ?

@Insti
Copy link
Collaborator

Insti commented Nov 9, 2016

What is $retrothresh set to?
Is your .tagtime file being found and loaded?
Does cygwin handle path separators "correctly"?

@mykter
Copy link
Author

mykter commented Nov 10, 2016

$retrothresh = 60; (but the error ones aren't being tagged as RETRO - those work fine)

I assume it is successfully loading my .tagtimerc file, as I have a non-default logfile path, which it is using.

I'm no cygwin expert unfortunately. I assume as it is loading both the .tagtimerc and log files, tagtime's use of path separators are working.

@Insti
Copy link
Collaborator

Insti commented Nov 10, 2016

Do the values of $ts, $ln and $nxtping look sensible?

Try adding

print "$ts, $ln, $nxtping\n"

between line 60 and 61

@mykter
Copy link
Author

mykter commented Nov 14, 2016

ts & ln have the values of the previous ping I answered, and nxtping has the time of the current ping.
So I see my original suggestion (an error margin on that check) is wrong, as it is comparing the previous ping time to the current ping time.

My new guess is that the editor function successfully invokes the editor window, but the launch function doesn't. It seems editor ensures $ENV{DISPLAY} is set, whereas launch doesn't - will try that.

@mykter
Copy link
Author

mykter commented Nov 14, 2016

Yep that did it, thanks for your help. So if this line from editor:
$ENV{DISPLAY} ||= ":0.0";
is missing from launch for a reason, then I suggest we add it wrapped in an if($cygwin) {

@Insti
Copy link
Collaborator

Insti commented Nov 14, 2016

It probably doesn't even need the if($cygwin) wrapper.
Would you be willing to submit a Pull request for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants